Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 1858833003: Move isNavigationAllowed() check to main entry point for loads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reflow comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed.
3 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
4 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 4 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
5 * Copyright (C) 2008 Alp Toker <alp@atoker.com> 5 * Copyright (C) 2008 Alp Toker <alp@atoker.com>
6 * Copyright (C) Research In Motion Limited 2009. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2009. All rights reserved.
7 * Copyright (C) 2011 Kris Jordan <krisjordan@gmail.com> 7 * Copyright (C) 2011 Kris Jordan <krisjordan@gmail.com>
8 * Copyright (C) 2011 Google Inc. All rights reserved. 8 * Copyright (C) 2011 Google Inc. All rights reserved.
9 * 9 *
10 * Redistribution and use in source and binary forms, with or without 10 * Redistribution and use in source and binary forms, with or without
(...skipping 876 matching lines...) Expand 10 before | Expand all | Expand 10 after
887 return policy; 887 return policy;
888 } 888 }
889 889
890 void FrameLoader::load(const FrameLoadRequest& passedRequest, FrameLoadType fram eLoadType, 890 void FrameLoader::load(const FrameLoadRequest& passedRequest, FrameLoadType fram eLoadType,
891 HistoryItem* historyItem, HistoryLoadType historyLoadType) 891 HistoryItem* historyItem, HistoryLoadType historyLoadType)
892 { 892 {
893 ASSERT(m_frame->document()); 893 ASSERT(m_frame->document());
894 894
895 RawPtr<LocalFrame> protect(m_frame.get()); 895 RawPtr<LocalFrame> protect(m_frame.get());
896 896
897 if (!m_frame->isNavigationAllowed())
898 return;
899
897 if (m_inStopAllLoaders) 900 if (m_inStopAllLoaders)
898 return; 901 return;
899 902
900 if (m_frame->page()->defersLoading() && isBackForwardLoadType(frameLoadType) ) { 903 if (m_frame->page()->defersLoading() && isBackForwardLoadType(frameLoadType) ) {
901 m_deferredHistoryLoad = DeferredHistoryLoad::create(passedRequest.resour ceRequest(), historyItem, frameLoadType, historyLoadType); 904 m_deferredHistoryLoad = DeferredHistoryLoad::create(passedRequest.resour ceRequest(), historyItem, frameLoadType, historyLoadType);
902 return; 905 return;
903 } 906 }
904 907
905 FrameLoadRequest request(passedRequest); 908 FrameLoadRequest request(passedRequest);
906 request.resourceRequest().setHasUserGesture(UserGestureIndicator::processing UserGesture()); 909 request.resourceRequest().setHasUserGesture(UserGestureIndicator::processing UserGesture());
(...skipping 677 matching lines...) Expand 10 before | Expand all | Expand 10 after
1584 // FIXME: We need a way to propagate insecure requests policy flags to 1587 // FIXME: We need a way to propagate insecure requests policy flags to
1585 // out-of-process frames. For now, we'll always use default behavior. 1588 // out-of-process frames. For now, we'll always use default behavior.
1586 if (!parentFrame->isLocalFrame()) 1589 if (!parentFrame->isLocalFrame())
1587 return nullptr; 1590 return nullptr;
1588 1591
1589 ASSERT(toLocalFrame(parentFrame)->document()); 1592 ASSERT(toLocalFrame(parentFrame)->document());
1590 return toLocalFrame(parentFrame)->document()->insecureNavigationsToUpgrade() ; 1593 return toLocalFrame(parentFrame)->document()->insecureNavigationsToUpgrade() ;
1591 } 1594 }
1592 1595
1593 } // namespace blink 1596 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698