Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1858813002: Update SkColorFilterImageFilter to sk_sp (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix bugs #

Patch Set 3 : update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -252 lines) Patch
M bench/ColorFilterBench.cpp View 10 chunks +66 lines, -82 lines 0 comments Download
M bench/ImageFilterCollapse.cpp View 4 chunks +7 lines, -12 lines 0 comments Download
M gm/coloremoji.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/colorfilterimagefilter.cpp View 2 chunks +11 lines, -15 lines 0 comments Download
M gm/dropshadowimagefilter.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M gm/fadefilter.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M gm/imagefilters.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gm/imagefiltersbase.cpp View 1 8 chunks +17 lines, -20 lines 0 comments Download
M gm/imagefilterscropexpand.cpp View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M gm/imagefilterscropped.cpp View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 1 2 4 chunks +16 lines, -12 lines 0 comments Download
M gm/recordopts.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M gm/tablecolorfilter.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M gm/testimagefilters.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M gm/tileimagefilter.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M include/effects/SkColorFilterImageFilter.h View 2 chunks +15 lines, -4 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 2 1 chunk +3 lines, -7 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 1 2 2 chunks +15 lines, -10 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 2 14 chunks +61 lines, -48 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
robertphillips
4 years, 8 months ago (2016-04-04 22:11:32 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858813002/20001
4 years, 8 months ago (2016-04-04 22:11:49 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 11:43:41 UTC) #8
robertphillips
ping
4 years, 8 months ago (2016-04-05 14:32:58 UTC) #9
f(malita)
lgtm
4 years, 8 months ago (2016-04-05 14:49:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858813002/20001
4 years, 8 months ago (2016-04-05 17:06:01 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/8386)
4 years, 8 months ago (2016-04-05 17:07:33 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858813002/40001
4 years, 8 months ago (2016-04-05 17:42:58 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 18:03:42 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858813002/40001
4 years, 8 months ago (2016-04-05 18:49:45 UTC) #21
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 18:50:46 UTC) #23
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/5605b56afa5bd89f3148b397318b616fccfd4004

Powered by Google App Engine
This is Rietveld 408576698