Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 18588: Remove spilled code from GenerateFastCaseSwitchJumpTable and Cases. (Closed)

Created:
11 years, 10 months ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove spilled code from GenerateFastCaseSwitchJumpTable and Cases. Committed: http://code.google.com/p/v8/source/detail?r=1168

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -19 lines) Patch
M src/codegen.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/codegen-ia32.cc View 1 2 1 chunk +29 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
William Hesse
11 years, 10 months ago (2009-01-26 14:52:54 UTC) #1
Kevin Millikin (Chromium)
LGTM. http://codereview.chromium.org/18588/diff/7/202 File src/codegen-ia32.cc (right): http://codereview.chromium.org/18588/diff/7/202#newcode1754 Line 1754: // check range of value, if outside ...
11 years, 10 months ago (2009-01-26 16:05:03 UTC) #2
William Hesse
11 years, 10 months ago (2009-01-27 07:52:59 UTC) #3
http://codereview.chromium.org/18588/diff/7/202
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/18588/diff/7/202#newcode1754
Line 1754: // check range of value, if outside [0..length-1] jump to default/end
label.
On 2009/01/26 16:05:03, Kevin Millikin wrote:
> Reformat (ie, capitalize) these comments while you're cleaning up this code.

Done.

http://codereview.chromium.org/18588/diff/7/202#newcode1791
Line 1791: // calculate address to overwrite later with actual address of table.
On 2009/01/26 16:05:03, Kevin Millikin wrote:
> Capitalize this one too.

Done.

Powered by Google App Engine
This is Rietveld 408576698