Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1858793002: Disable Bytecodes.DecodeBytecodeAndOperands for big-endian. (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable Bytecodes.DecodeBytecodeAndOperands for big-endian. Because the operands in this test are encoded in little endian format. Therefore, their bytes are all swapped when reading them on big endian machine. R=mbrandy@us.ibm.com,joransiu@ca.ibm.com,titzer@chromium.org,machenbach@chromium.org,bradnelson@chromium.org,ahaas@chromium.org BUG= Committed: https://crrev.com/99eea1e109b2d8b3c4cdcc94fb4b2bfe0afd2e53 Cr-Commit-Position: refs/heads/master@{#35262}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/unittests/unittests.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-05 03:13:21 UTC) #1
titzer
lgtm
4 years, 8 months ago (2016-04-05 07:47:16 UTC) #2
Michael Achenbach
lgtm
4 years, 8 months ago (2016-04-05 08:10:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858793002/1
4 years, 8 months ago (2016-04-05 12:53:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 13:26:09 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 13:27:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99eea1e109b2d8b3c4cdcc94fb4b2bfe0afd2e53
Cr-Commit-Position: refs/heads/master@{#35262}

Powered by Google App Engine
This is Rietveld 408576698