Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1858783002: [Media Router] Move media_router.mojom to c/b/media/router/mojo (Closed)

Created:
4 years, 8 months ago by mark a. foltz
Modified:
4 years, 8 months ago
Reviewers:
benwells, Wez
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), extensions-reviews_chromium.org, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, media-router+watch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Move media_router.mojom to c/b/media/router/mojo This completes the co-location of the Mojo-related code in Media Router. It also adds a missing dependency from MR onto //content/public/browser. BUG=596999 Committed: https://crrev.com/a60c1f4211ff0113e3ceb514b7b6297c070f37d3 Cr-Commit-Position: refs/heads/master@{#385114}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Respond to wez@ comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -367 lines) Patch
M chrome/browser/media/router/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/media/router/media_router.gyp View 1 3 chunks +4 lines, -4 lines 0 comments Download
D chrome/browser/media/router/media_router.mojom View 1 chunk +0 lines, -355 lines 0 comments Download
A + chrome/browser/media/router/mojo/media_router.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/router/mojo/media_router_type_converters.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/extensions_renderer_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/media_router_bindings.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
mark a. foltz
benwells@: PTAL at extensions/renderer wez@: PTAL at everything
4 years, 8 months ago (2016-04-04 20:47:34 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858783002/1
4 years, 8 months ago (2016-04-04 20:48:30 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-04 21:46:10 UTC) #7
Wez
lgtm https://codereview.chromium.org/1858783002/diff/1/chrome/browser/media/router/media_router.gyp File chrome/browser/media/router/media_router.gyp (right): https://codereview.chromium.org/1858783002/diff/1/chrome/browser/media/router/media_router.gyp#newcode23 chrome/browser/media/router/media_router.gyp:23: '<(DEPTH)/content/content.gyp:content_browser', nit: Ordering; this should appear after keyed_service_core?
4 years, 8 months ago (2016-04-04 23:33:48 UTC) #8
benwells
lgtm
4 years, 8 months ago (2016-04-05 00:26:06 UTC) #9
mark a. foltz
On 2016/04/04 at 23:33:48, wez wrote: > lgtm > > https://codereview.chromium.org/1858783002/diff/1/chrome/browser/media/router/media_router.gyp > File chrome/browser/media/router/media_router.gyp (right): ...
4 years, 8 months ago (2016-04-05 06:18:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858783002/20001
4 years, 8 months ago (2016-04-05 06:19:16 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 06:59:12 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 07:00:14 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a60c1f4211ff0113e3ceb514b7b6297c070f37d3
Cr-Commit-Position: refs/heads/master@{#385114}

Powered by Google App Engine
This is Rietveld 408576698