third_party/WebKit/Source/core/css/FontFaceCache.h - Issue 1858753003: Remove RawPtr from core/css

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/FontFaceCache.h

Issue 1858753003: Remove RawPtr from core/css (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/FontFaceCache.h

diff --git a/third_party/WebKit/Source/core/css/FontFaceCache.h b/third_party/WebKit/Source/core/css/FontFaceCache.h

index 11ea85550d4ea9ed0d3143055c0faa4dcea7b805..64f083e57d3eff330b36df9b054d7361dda17e8e 100644

--- a/third_party/WebKit/Source/core/css/FontFaceCache.h

+++ b/third_party/WebKit/Source/core/css/FontFaceCache.h

@@ -48,11 +48,11 @@ public:

// FIXME: Remove CSSFontSelector as argument. Passing CSSFontSelector here is

// a result of egregious spaghettification in FontFace/FontFaceSet.

- void add(CSSFontSelector*, const StyleRuleFontFace*, RawPtr<FontFace>);

+ void add(CSSFontSelector*, const StyleRuleFontFace*, FontFace*);

void remove(const StyleRuleFontFace*);

void clearCSSConnected();

void clearAll();

- void addFontFace(CSSFontSelector*, RawPtr<FontFace>, bool cssConnected);

+ void addFontFace(CSSFontSelector*, FontFace*, bool cssConnected);

void removeFontFace(FontFace*, bool cssConnected);

// FIXME: It's sort of weird that add/remove uses StyleRuleFontFace* as key,