Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: chrome/browser/task_manager/extension_process_resource_provider.cc

Issue 185873003: Task Manager: overhaul & re-enable task manager browser tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Retry upload Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/extension_process_resource_provider.cc
diff --git a/chrome/browser/task_manager/extension_process_resource_provider.cc b/chrome/browser/task_manager/extension_process_resource_provider.cc
index 247833b66033b3ab7214dce1b3f83fc1fb63429d..b14f4e296d9ae5aef0e85ea77fe0a28cb62c18a9 100644
--- a/chrome/browser/task_manager/extension_process_resource_provider.cc
+++ b/chrome/browser/task_manager/extension_process_resource_provider.cc
@@ -300,17 +300,12 @@ bool ExtensionProcessResourceProvider::
if (web_contents->GetRenderProcessHost()->IsGuest())
return false;
extensions::ViewType view_type = extensions::GetViewType(web_contents);
- // Don't add WebContents (those are handled by
- // TabContentsResourceProvider) or background contents (handled
- // by BackgroundResourceProvider).
-#if defined(USE_ASH)
- return (view_type != extensions::VIEW_TYPE_TAB_CONTENTS &&
- view_type != extensions::VIEW_TYPE_BACKGROUND_CONTENTS);
-#else
+ // Don't add tab contents (those are handled by TabContentsResourceProvider)
+ // or background contents (handled by BackgroundResourceProvider) or panels
+ // (handled by PanelResourceProvider)
return (view_type != extensions::VIEW_TYPE_TAB_CONTENTS &&
view_type != extensions::VIEW_TYPE_BACKGROUND_CONTENTS &&
view_type != extensions::VIEW_TYPE_PANEL);
-#endif // USE_ASH
}
void ExtensionProcessResourceProvider::AddToTaskManager(
@@ -318,10 +313,10 @@ void ExtensionProcessResourceProvider::AddToTaskManager(
if (!IsHandledByThisProvider(render_view_host))
return;
+ if (resources_.count(render_view_host))
+ return;
ExtensionProcessResource* resource =
new ExtensionProcessResource(render_view_host);
- if (resources_.find(render_view_host) != resources_.end())
- return;
resources_[render_view_host] = resource;
task_manager_->AddResource(resource);
}
« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/browser/task_manager/notification_resource_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698