Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1858703003: Remove unused fields under components/test_runner (Closed)

Created:
4 years, 8 months ago by Łukasz Anforowicz
Modified:
4 years, 8 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, mlamouri+watch-test-runner_chromium.org, jochen+watch_chromium.org, site-isolation-reviews_chromium.org, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused fields under components/test_runner This CL was created using Scythe (Googlers only tool, sorry...). See go/scythe for more details. BUG=600434 Committed: https://crrev.com/e7b4a0b053f022a97b23576eeed6ebfac0110f2b Cr-Commit-Position: refs/heads/master@{#385495}

Patch Set 1 #

Patch Set 2 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M components/test_runner/mock_web_media_stream_center.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/test_runner/mock_web_media_stream_center.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/test_runner/mock_web_user_media_client.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/test_runner/test_preferences.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858703003/1
4 years, 8 months ago (2016-04-04 18:09:14 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-04 19:07:22 UTC) #4
Łukasz Anforowicz
dmazzoni@, could you please do an owners review for components/test_runner? this CL just removes dead ...
4 years, 8 months ago (2016-04-04 19:20:01 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858703003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858703003/20001
4 years, 8 months ago (2016-04-06 16:21:39 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 16:56:22 UTC) #10
dmazzoni
lgtm
4 years, 8 months ago (2016-04-06 17:21:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858703003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858703003/20001
4 years, 8 months ago (2016-04-06 17:22:00 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-06 17:28:22 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 17:30:48 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e7b4a0b053f022a97b23576eeed6ebfac0110f2b
Cr-Commit-Position: refs/heads/master@{#385495}

Powered by Google App Engine
This is Rietveld 408576698