Type::GetName() for printing types in debugger

src/types.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
 //       with the distribution.
 //     * Neither the name of Google Inc. nor the names of its
 //       contributors may be used to endorse or promote products derived
 //       from this software without specific prior written permission.
 //
 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #include "types.h"
+#include "string-stream.h"
 
 namespace v8 {
 namespace internal {
 
 int Type::NumClasses() {
   if (is_class()) {
     return 1;
   } else if (is_union()) {
     Handle<Unioned> unioned = as_union();
     int result = 0;
@@ skipping 430 matching lines @@
   return from_handle(result);
 }
 
 
 Type* Type::Optional(Handle<Type> type) {
   return type->is_bitset()
       ? from_bitset(type->as_bitset() | kUndefined)
       : Union(type, Undefined()->handle_via_isolate_of(*type));
 }
 
+
+SmartArrayPointer<const char> Type::GetName() {
+  char buffer[200];

[rossberg, 2013/07/08 11:20:05]

200 seems fragile. I'd drop this method altogether and recurse directly in the
main method below. You can do that by eliminating the use of SmallListPrinter,
which seems more trouble than it's worth here.

+  NoAllocationStringAllocator allocator(buffer,
+      static_cast<unsigned>(sizeof(buffer)));
+  StringStream stream(&allocator);
+  PrintName(&stream);
+  return stream.ToCString();
+}
+
+
+void Type::PrintName(StringStream* stream) {
+  if (is_bitset()) {
+    int val = as_bitset();
+    const char* composed_name = GetComposedName(val);
+    if (composed_name != NULL) {
+      stream->Add(composed_name);
+      return;
+    }
+    SimpleListPrinter printer(stream);

[rossberg, 2013/07/08 11:20:05]

Can we put a "{...}" around the list?

+    for (unsigned i = 0; i < sizeof(val)*8; ++i) {
+      int mask = (1<<i);
+      if ((val & mask) != 0) {
+        printer.Add(GetPrimitiveName(mask));
+      }
+    }
+  } else if (is_constant()) {
+    stream->Add("Constant(");
+    stream->Add("0x%x", *as_constant());
+    stream->Add(")");
+  } else if (is_class()) {
+    stream->Add("Class(");
+    stream->Add("0x%x", *as_class());
+    stream->Add(")");
+  } else if (is_union()) {
+    Handle<Unioned> unioned = as_union();
+    SimpleListPrinter printer(stream);

[rossberg, 2013/07/08 11:20:05]

Can we put a "{...}" around the list?

+    for (int i = 0; i < unioned->length(); ++i) {
+      Handle<Type> type_i = union_get(unioned, i);
+      printer.Add(*type_i->GetName());
+    }
+  }
+}
+
+
 } }  // namespace v8::internal