Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 1858683002: Revert of GN: Make breakpad_unittests & sandbox_linux_unittests use test() (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@test-minor-renames
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of GN: Make breakpad_unittests & sandbox_linux_unittests use test() (patchset #2 id:200001 of https://codereview.chromium.org/1854733003/ ) Reason for revert: Still breaking bots: crbug.com/600342 Original issue's description: > Reland of GN: Make breakpad_unittests & sandbox_linux_unittests use test() > > Reason for revert: > Now doesn't use obj/ directory > > This simplifies build rules for native tests, and allows us to get rid > of ${target}_deps targets (once recipes are updated). > > This change fixes the generated wrapper scripts, which didn't work. > > TBR=jorgelo > BUG=589318 > > Committed: https://crrev.com/66605a610bce190e818ebfc73913a126c025ffb3 > Cr-Commit-Position: refs/heads/master@{#384658} TBR=mark@chromium.org,dpranke@chromium.org,jorgelo@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=589318 Committed: https://crrev.com/e30b022bb758a10e9ecea81d5433bd1e046ccac4 Cr-Commit-Position: refs/heads/master@{#384949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -187 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M breakpad/BUILD.gn View 3 chunks +26 lines, -3 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 2 chunks +5 lines, -24 lines 0 comments Download
M build/android/test_runner.py View 1 chunk +0 lines, -2 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +7 lines, -17 lines 0 comments Download
M build/config/android/rules.gni View 2 chunks +37 lines, -21 lines 0 comments Download
M sandbox/linux/BUILD.gn View 2 chunks +39 lines, -8 lines 0 comments Download
M testing/test.gni View 2 chunks +94 lines, -111 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
agrieve
Created Revert of GN: Make breakpad_unittests & sandbox_linux_unittests use test()
4 years, 8 months ago (2016-04-04 15:51:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858683002/1
4 years, 8 months ago (2016-04-04 15:52:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858683002/1
4 years, 8 months ago (2016-04-04 16:01:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858683002/1
4 years, 8 months ago (2016-04-04 16:31:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858683002/1
4 years, 8 months ago (2016-04-04 17:01:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858683002/1
4 years, 8 months ago (2016-04-04 17:31:55 UTC) #6
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-04 17:36:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 17:57:07 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e30b022bb758a10e9ecea81d5433bd1e046ccac4 Cr-Commit-Position: refs/heads/master@{#384949}
4 years, 8 months ago (2016-04-04 17:59:45 UTC) #11
agrieve
4 years, 8 months ago (2016-04-04 19:28:53 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1854233002/ by agrieve@chromium.org.

The reason for reverting is: attempt 3 here we come!.

Powered by Google App Engine
This is Rietveld 408576698