[Sync] Inject startup dependencies into StartupController.

components/sync_driver/startup_controller_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sync_driver/startup_controller.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/time/time.h"
-#include "components/signin/core/browser/fake_profile_oauth2_token_service.h"
-#include "components/sync_driver/signin_manager_wrapper.h"
 #include "components/sync_driver/sync_driver_switches.h"
 #include "components/sync_driver/sync_prefs.h"
 #include "components/syncable_prefs/testing_pref_service_syncable.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace browser_sync {
 
-static const char kTestUser[] = "test@gmail.com";
-static const char kTestToken[] = "testToken";
-
 // These are coupled to the implementation of StartupController's
 // GetBackendInitializationStateString which is used by about:sync. We use it
 // as a convenient way to verify internal state and that the class is
 // outputting the correct values for the debug string.
 static const char kStateStringStarted[] = "Started";
 static const char kStateStringDeferred[] = "Deferred";
 static const char kStateStringNotStarted[] = "Not started";
 
-class FakeSigninManagerWrapper : public SigninManagerWrapper {
- public:
-  FakeSigninManagerWrapper() : SigninManagerWrapper(NULL) {}
-  std::string GetEffectiveUsername() const override { return std::string(); }
-
-  std::string GetAccountIdToUse() const override { return account_id_; }
-
-  void set_account_id(const std::string& account_id) {
-    account_id_ = account_id;
-  }
-
- private:
-  std::string account_id_;
-};
-
 class StartupControllerTest : public testing::Test {
  public:
-  StartupControllerTest() : started_(false) {}
+  StartupControllerTest() : can_start_(false), started_(false) {}
 
   void SetUp() override {
     sync_driver::SyncPrefs::RegisterProfilePrefs(pref_service_.registry());
     sync_prefs_.reset(new sync_driver::SyncPrefs(&pref_service_));
-    token_service_.reset(new FakeProfileOAuth2TokenService());
-    signin_.reset(new FakeSigninManagerWrapper());
-
-    SetUpController();
-  }
-
-  void TearDown() override {
-    controller_.reset();
-    signin_.reset();
-    token_service_->Shutdown();
-    token_service_.reset();
-    sync_prefs_.reset();
-    started_ = false;
-  }
-
-  void SetUpController() {
-    started_ = false;
-    base::Closure fake_start_backend = base::Bind(
-        &StartupControllerTest::FakeStartBackend, base::Unretained(this));
-    controller_.reset(new StartupController(token_service(), sync_prefs_.get(),
-                                            signin_.get(), fake_start_backend));
+    controller_.reset(new StartupController(
+        sync_prefs_.get(),
+        base::Bind(&StartupControllerTest::CanStart, base::Unretained(this)),
+        base::Bind(&StartupControllerTest::FakeStartBackend,
+                   base::Unretained(this))));
     controller_->Reset(syncer::UserTypes());
     controller_->OverrideFallbackTimeoutForTest(
         base::TimeDelta::FromSeconds(0));
   }
 
+  void TearDown() override {
+    controller_.reset();

[Nicolas Zea, 2016/04/04 20:44:17]

is it necessary to have these here? These will automatically get destroyed when
after the test runs anyways right?

[maxbogue, 2016/04/04 22:56:55]

Good catch! They must have been explicitly called before to ensure some ordering
wrt the token service Shutdown() call. Shouldn't be needed now; I've removed the
whole method and made |controller_| the last member variable so it still gets
destroyed first.

+    sync_prefs_.reset();
+    started_ = false;
+  }
+
+  bool CanStart() { return can_start_; }
+
+  void SetCanStart(bool can_start) { can_start_ = can_start; }
+
   void FakeStartBackend() {
     started_ = true;
     sync_prefs()->SetFirstSetupComplete();
   }
 
   void ExpectStarted() {
     EXPECT_TRUE(started());
     EXPECT_EQ(kStateStringStarted,
               controller()->GetBackendInitializationStateString());
   }
 
   void ExpectStartDeferred() {
     const bool deferred_start =
         !base::CommandLine::ForCurrentProcess()->HasSwitch(
             switches::kSyncDisableDeferredStartup);
     EXPECT_EQ(!deferred_start, started());
     EXPECT_EQ(deferred_start ? kStateStringDeferred : kStateStringStarted,
               controller()->GetBackendInitializationStateString());
   }
 
   void ExpectNotStarted() {
     EXPECT_FALSE(started());
     EXPECT_EQ(kStateStringNotStarted,
               controller()->GetBackendInitializationStateString());
   }
 
   bool started() const { return started_; }
   void clear_started() { started_ = false; }
   StartupController* controller() { return controller_.get(); }
-  FakeSigninManagerWrapper* signin() { return signin_.get(); }
-  FakeProfileOAuth2TokenService* token_service() {
-    return token_service_.get();
-  }
   sync_driver::SyncPrefs* sync_prefs() { return sync_prefs_.get(); }
 
  private:
+  bool can_start_;
   bool started_;
   base::MessageLoop message_loop_;
   syncable_prefs::TestingPrefServiceSyncable pref_service_;
   scoped_ptr<StartupController> controller_;
-  scoped_ptr<FakeSigninManagerWrapper> signin_;
-  scoped_ptr<FakeProfileOAuth2TokenService> token_service_;
   scoped_ptr<sync_driver::SyncPrefs> sync_prefs_;
 };
 
 // Test that sync doesn't start until all conditions are met.
 TEST_F(StartupControllerTest, Basic) {
   controller()->TryStart();
   ExpectNotStarted();
 
+  SetCanStart(true);
+  controller()->TryStart();
+  ExpectStarted();
+}
+
+// Test that sync defers if first setup is complete.
+TEST_F(StartupControllerTest, DefersAfterFirstSetupComplete) {
   sync_prefs()->SetFirstSetupComplete();
-  controller()->TryStart();
-  ExpectNotStarted();
-
-  signin()->set_account_id(kTestUser);
-  controller()->TryStart();
-  ExpectNotStarted();
-
-  token_service()->UpdateCredentials(kTestUser, kTestToken);
+  SetCanStart(true);
   controller()->TryStart();
   ExpectStartDeferred();
 }
 
-// Test that sync doesn't start when not requested even if all other
-// conditons are met.
-TEST_F(StartupControllerTest, NotRequested) {
-  sync_prefs()->SetFirstSetupComplete();
-  sync_prefs()->SetSyncRequested(false);
-  signin()->set_account_id(kTestUser);
-  token_service()->UpdateCredentials(kTestUser, kTestToken);
-  controller()->TryStart();
-  ExpectNotStarted();
-}
-
-// Test that sync doesn't when managed even if all other conditons are met.
-TEST_F(StartupControllerTest, Managed) {
-  sync_prefs()->SetFirstSetupComplete();
-  sync_prefs()->SetManagedForTest(true);
-  signin()->set_account_id(kTestUser);
-  token_service()->UpdateCredentials(kTestUser, kTestToken);
-  controller()->TryStart();
-  ExpectNotStarted();
-}
-
 // Test that a data type triggering startup starts sync immediately.
 TEST_F(StartupControllerTest, NoDeferralDataTypeTrigger) {
   sync_prefs()->SetFirstSetupComplete();
-  signin()->set_account_id(kTestUser);
-  token_service()->UpdateCredentials(kTestUser, kTestToken);
+  SetCanStart(true);
   controller()->OnDataTypeRequestsSyncStartup(syncer::SESSIONS);
   ExpectStarted();
 }
 
 // Test that a data type trigger interrupts the deferral timer and starts
 // sync immediately.
 TEST_F(StartupControllerTest, DataTypeTriggerInterruptsDeferral) {
   sync_prefs()->SetFirstSetupComplete();
-  signin()->set_account_id(kTestUser);
-  token_service()->UpdateCredentials(kTestUser, kTestToken);
+  SetCanStart(true);
   controller()->TryStart();
   ExpectStartDeferred();
 
   controller()->OnDataTypeRequestsSyncStartup(syncer::SESSIONS);
   ExpectStarted();
 
   // The fallback timer shouldn't result in another invocation of the closure
   // we passed to the StartupController.
   clear_started();
   base::RunLoop().RunUntilIdle();
   EXPECT_FALSE(started());
 }
 
 // Test that the fallback timer starts sync in the event all
 // conditions are met and no data type requests sync.
 TEST_F(StartupControllerTest, FallbackTimer) {
   sync_prefs()->SetFirstSetupComplete();
-  signin()->set_account_id(kTestUser);
-  token_service()->UpdateCredentials(kTestUser, kTestToken);
+  SetCanStart(true);
   controller()->TryStart();
   ExpectStartDeferred();
 
   base::RunLoop().RunUntilIdle();
   ExpectStarted();
 }
 
 // Test that we start immediately if sessions is disabled.
 TEST_F(StartupControllerTest, NoDeferralWithoutSessionsSync) {
   syncer::ModelTypeSet types(syncer::UserTypes());
   // Disabling sessions means disabling 4 types due to groupings.
   types.Remove(syncer::SESSIONS);
   types.Remove(syncer::PROXY_TABS);
   types.Remove(syncer::TYPED_URLS);
   types.Remove(syncer::SUPERVISED_USER_SETTINGS);
   sync_prefs()->SetKeepEverythingSynced(false);
   sync_prefs()->SetPreferredDataTypes(syncer::UserTypes(), types);
   controller()->Reset(syncer::UserTypes());
+
   sync_prefs()->SetFirstSetupComplete();
-
-  signin()->set_account_id(kTestUser);
-  token_service()->UpdateCredentials(kTestUser, kTestToken);
+  SetCanStart(true);
   controller()->TryStart();
   ExpectStarted();
 }
 
 // Sanity check that the fallback timer doesn't fire before startup
 // conditions are met.
 TEST_F(StartupControllerTest, FallbackTimerWaits) {
   controller()->TryStart();
   ExpectNotStarted();
   base::RunLoop().RunUntilIdle();
   ExpectNotStarted();
 }
 
 // Test that sync starts immediately when setup in progress is true.
 TEST_F(StartupControllerTest, NoDeferralSetupInProgressTrigger) {
   sync_prefs()->SetFirstSetupComplete();
-  signin()->set_account_id(kTestUser);
-  token_service()->UpdateCredentials(kTestUser, kTestToken);
-
+  SetCanStart(true);
   controller()->SetSetupInProgress(true);
   ExpectStarted();
 }
 
 // Test that setup in progress being set to true interrupts the deferral timer
 // and starts sync immediately.
 TEST_F(StartupControllerTest, SetupInProgressTriggerInterruptsDeferral) {
   sync_prefs()->SetFirstSetupComplete();
-  signin()->set_account_id(kTestUser);
-  token_service()->UpdateCredentials(kTestUser, kTestToken);
+  SetCanStart(true);
   controller()->TryStart();
   ExpectStartDeferred();
 
   controller()->SetSetupInProgress(true);
   ExpectStarted();
 }
 
 // Test that start isn't deferred on the first start but is on restarts.
 TEST_F(StartupControllerTest, DeferralOnRestart) {
-  signin()->set_account_id(kTestUser);
-  token_service()->UpdateCredentials(kTestUser, kTestToken);
+  SetCanStart(true);
   controller()->TryStart();
   ExpectStarted();
 
   clear_started();
   controller()->Reset(syncer::UserTypes());
   ExpectNotStarted();
   controller()->TryStart();
   ExpectStartDeferred();
 }
 
 // Test that setup-in-progress tracking is persistent across a Reset.
 TEST_F(StartupControllerTest, ResetDuringSetup) {
-  signin()->set_account_id(kTestUser);
-  token_service()->UpdateCredentials(kTestUser, kTestToken);
+  SetCanStart(true);
 
   // Simulate UI telling us setup is in progress.
   controller()->SetSetupInProgress(true);
 
   // This could happen if the UI triggers a stop-syncing permanently call.
   controller()->Reset(syncer::UserTypes());
 
   // From the UI's point of view, setup is still in progress.
   EXPECT_TRUE(controller()->IsSetupInProgress());
 }
 
 }  // namespace browser_sync