bluetooth: Populate Web Bluetooth blacklist from variations:: parameter.

bluetooth: Populate Web Bluetooth blacklist from variations:: parameter.

Enables rapid deployment of new blacklisted UUIDs for the
Web Bluetooth [blacklist] via field trial variation parameters.

[blacklist] https://webbluetoothcg.github.io/web-bluetooth/#the-gatt-blacklist

Includes a browsertest, but also tested manually with blacklist parms of:
180d:e                (heart rate excluded)
1111:e,180d:e,2222:e  (heart rate excluded)
1111:e,180d:w,2222:e  (heart rate write excluded, allows reading)
using command line parameters similar to:
--force-fieldtrials=WebBluetoothBlacklist/Group1 --force-fieldtrial-params=WebBluetoothBlacklist.Group1:blacklist_additions/1111%3ae%2c180d%3ae%2c2222%3ae
(colon and comma escaped with %3a and %2c)

BUG=570121
Committed: https://crrev.com/74250325d5c35950caa4a90b12045b41ff7f869a
Cr-Commit-Position: refs/heads/master@{#385644}

[scheib, 2016-04-04 18:41:10]

scheib@chromium.org changed reviewers:
+ jyasskin@chromium.org

[Jeffrey Yasskin, 2016-04-05 17:58:55]

LGTM as long as a Finch person signs off on it. Thanks!

asvitkine@ said not to mention Finch in CL descriptions.

https://codereview.chromium.org/1858633003/diff/20001/content/browser/bluetoo...
File content/browser/bluetooth/bluetooth_blacklist.h (right):

https://codereview.chromium.org/1858633003/diff/20001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_blacklist.h:93: // to be updated at any
time.
This is still only updated on restart, right?

https://codereview.chromium.org/1858633003/diff/20001/content/public/browser/...
File content/public/browser/content_browser_client.h (right):

https://codereview.chromium.org/1858633003/diff/20001/content/public/browser/...
content/public/browser/content_browser_client.h:418: // Returns a blacklist of
UUIDs that have restrictions when accessed
Could you mention that these are parsed by BluetoothBlacklist::Add()? That way
if someone wants to change either side, they're pointed to the other one.

[scheib, 2016-04-05 18:40:32]

Description was changed from

==========
bluetooth: Populate Web Bluetooth blacklist from Finch variations.

Enables rapid deployment of new blacklisted UUIDs for the
Web Bluetooth [blacklist] via field trial variation parameters.

[blacklist] https://webbluetoothcg.github.io/web-bluetooth/#the-gatt-blacklist

BUG=570121
==========

to

==========
bluetooth: Populate Web Bluetooth blacklist from variations:: parameter.

Enables rapid deployment of new blacklisted UUIDs for the
Web Bluetooth [blacklist] via field trial variation parameters.

[blacklist] https://webbluetoothcg.github.io/web-bluetooth/#the-gatt-blacklist

BUG=570121
==========

[scheib, 2016-04-05 18:43:37]

scheib@chromium.org changed reviewers:
+ holte@chromium.org, jam@chromium.org

[scheib, 2016-04-05 18:43:37]

holte: PTAL w.r.t. use of variations::GetVariationParamValue.
jam: PTAL as content/public OWNER.

jyasskin: Thanks. 

> asvitkine@ said not to mention Finch in CL descriptions.
Done.

https://codereview.chromium.org/1858633003/diff/20001/content/browser/bluetoo...
File content/browser/bluetooth/bluetooth_blacklist.h (right):

https://codereview.chromium.org/1858633003/diff/20001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_blacklist.h:93: // to be updated at any
time.
On 2016/04/05 17:58:55, Jeffrey Yasskin wrote:
> This is still only updated on restart, right?

Done.

https://codereview.chromium.org/1858633003/diff/20001/content/public/browser/...
File content/public/browser/content_browser_client.h (right):

https://codereview.chromium.org/1858633003/diff/20001/content/public/browser/...
content/public/browser/content_browser_client.h:418: // Returns a blacklist of
UUIDs that have restrictions when accessed
On 2016/04/05 17:58:55, Jeffrey Yasskin wrote:
> Could you mention that these are parsed by BluetoothBlacklist::Add()? That way
> if someone wants to change either side, they're pointed to the other one.

Done.

[jam, 2016-04-05 22:35:45]

lgtm

https://codereview.chromium.org/1858633003/diff/40001/chrome/browser/chrome_c...
File chrome/browser/chrome_content_browser_client.h (right):

https://codereview.chromium.org/1858633003/diff/40001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_client.h:176: 
nit: there shouldn't be blank lines here and on line 169 per convention

https://codereview.chromium.org/1858633003/diff/40001/content/public/browser/...
File content/public/browser/content_browser_client.cc (right):

https://codereview.chromium.org/1858633003/diff/40001/content/public/browser/...
content/public/browser/content_browser_client.cc:229: return "";
nit: return std::string()

[scheib, 2016-04-05 23:02:54]

https://codereview.chromium.org/1858633003/diff/40001/chrome/browser/chrome_c...
File chrome/browser/chrome_content_browser_client.h (right):

https://codereview.chromium.org/1858633003/diff/40001/chrome/browser/chrome_c...
chrome/browser/chrome_content_browser_client.h:176: 
On 2016/04/05 22:35:44, jam wrote:
> nit: there shouldn't be blank lines here and on line 169 per convention 

Done.

https://codereview.chromium.org/1858633003/diff/40001/content/public/browser/...
File content/public/browser/content_browser_client.cc (right):

https://codereview.chromium.org/1858633003/diff/40001/content/public/browser/...
content/public/browser/content_browser_client.cc:229: return "";
On 2016/04/05 22:35:45, jam wrote:
> nit: return std::string()

Done.

[scheib, 2016-04-06 22:04:47]

Description was changed from

==========
bluetooth: Populate Web Bluetooth blacklist from variations:: parameter.

Enables rapid deployment of new blacklisted UUIDs for the
Web Bluetooth [blacklist] via field trial variation parameters.

[blacklist] https://webbluetoothcg.github.io/web-bluetooth/#the-gatt-blacklist

BUG=570121
==========

to

==========
bluetooth: Populate Web Bluetooth blacklist from variations:: parameter.

Enables rapid deployment of new blacklisted UUIDs for the
Web Bluetooth [blacklist] via field trial variation parameters.

[blacklist] https://webbluetoothcg.github.io/web-bluetooth/#the-gatt-blacklist

Includes a browsertest, but also tested manually with blacklist parms of:
180d:e                (heart rate excluded)
1111:e,180d:e,2222:e  (heart rate excluded)
1111:e,180d:w,2222:e  (heart rate write excluded, allows reading)
using command line parameters similar to:
--force-fieldtrials=WebBluetoothBlacklist/Group1
--force-fieldtrial-params=WebBluetoothBlacklist.Group1:blacklist_additions/1111%3ae%2c180d%3ae%2c2222%3ae
(colon and comma escaped with %3a and %2c)
BUG=570121
==========

[scheib, 2016-04-06 22:04:57]

Description was changed from

==========
bluetooth: Populate Web Bluetooth blacklist from variations:: parameter.

Enables rapid deployment of new blacklisted UUIDs for the
Web Bluetooth [blacklist] via field trial variation parameters.

[blacklist] https://webbluetoothcg.github.io/web-bluetooth/#the-gatt-blacklist

Includes a browsertest, but also tested manually with blacklist parms of:
180d:e                (heart rate excluded)
1111:e,180d:e,2222:e  (heart rate excluded)
1111:e,180d:w,2222:e  (heart rate write excluded, allows reading)
using command line parameters similar to:
--force-fieldtrials=WebBluetoothBlacklist/Group1
--force-fieldtrial-params=WebBluetoothBlacklist.Group1:blacklist_additions/1111%3ae%2c180d%3ae%2c2222%3ae
(colon and comma escaped with %3a and %2c)
BUG=570121
==========

to

==========
bluetooth: Populate Web Bluetooth blacklist from variations:: parameter.

Enables rapid deployment of new blacklisted UUIDs for the
Web Bluetooth [blacklist] via field trial variation parameters.

[blacklist] https://webbluetoothcg.github.io/web-bluetooth/#the-gatt-blacklist

Includes a browsertest, but also tested manually with blacklist parms of:
180d:e                (heart rate excluded)
1111:e,180d:e,2222:e  (heart rate excluded)
1111:e,180d:w,2222:e  (heart rate write excluded, allows reading)
using command line parameters similar to:
--force-fieldtrials=WebBluetoothBlacklist/Group1
--force-fieldtrial-params=WebBluetoothBlacklist.Group1:blacklist_additions/1111%3ae%2c180d%3ae%2c2222%3ae
(colon and comma escaped with %3a and %2c)

BUG=570121
==========

[Steven Holte, 2016-04-06 22:28:14]

Use of variations::GetVariationParamValue lgtm

[scheib, 2016-04-06 23:05:46]

The CQ bit was checked by scheib@chromium.org

[scheib, 2016-04-06 23:05:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
jyasskin@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1858633003/#ps60001
(title: "addressed jam comments")

[commit-bot: I haz the power, 2016-04-06 23:07:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858633003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858633003/60001

[commit-bot: I haz the power, 2016-04-07 03:32:34]

Description was changed from

==========
bluetooth: Populate Web Bluetooth blacklist from variations:: parameter.

Enables rapid deployment of new blacklisted UUIDs for the
Web Bluetooth [blacklist] via field trial variation parameters.

[blacklist] https://webbluetoothcg.github.io/web-bluetooth/#the-gatt-blacklist

Includes a browsertest, but also tested manually with blacklist parms of:
180d:e                (heart rate excluded)
1111:e,180d:e,2222:e  (heart rate excluded)
1111:e,180d:w,2222:e  (heart rate write excluded, allows reading)
using command line parameters similar to:
--force-fieldtrials=WebBluetoothBlacklist/Group1
--force-fieldtrial-params=WebBluetoothBlacklist.Group1:blacklist_additions/1111%3ae%2c180d%3ae%2c2222%3ae
(colon and comma escaped with %3a and %2c)

BUG=570121
==========

to

==========
bluetooth: Populate Web Bluetooth blacklist from variations:: parameter.

Enables rapid deployment of new blacklisted UUIDs for the
Web Bluetooth [blacklist] via field trial variation parameters.

[blacklist] https://webbluetoothcg.github.io/web-bluetooth/#the-gatt-blacklist

Includes a browsertest, but also tested manually with blacklist parms of:
180d:e                (heart rate excluded)
1111:e,180d:e,2222:e  (heart rate excluded)
1111:e,180d:w,2222:e  (heart rate write excluded, allows reading)
using command line parameters similar to:
--force-fieldtrials=WebBluetoothBlacklist/Group1
--force-fieldtrial-params=WebBluetoothBlacklist.Group1:blacklist_additions/1111%3ae%2c180d%3ae%2c2222%3ae
(colon and comma escaped with %3a and %2c)

BUG=570121
==========

[commit-bot: I haz the power, 2016-04-07 03:32:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-07 03:34:40]

Description was changed from

==========
bluetooth: Populate Web Bluetooth blacklist from variations:: parameter.

Enables rapid deployment of new blacklisted UUIDs for the
Web Bluetooth [blacklist] via field trial variation parameters.

[blacklist] https://webbluetoothcg.github.io/web-bluetooth/#the-gatt-blacklist

Includes a browsertest, but also tested manually with blacklist parms of:
180d:e                (heart rate excluded)
1111:e,180d:e,2222:e  (heart rate excluded)
1111:e,180d:w,2222:e  (heart rate write excluded, allows reading)
using command line parameters similar to:
--force-fieldtrials=WebBluetoothBlacklist/Group1
--force-fieldtrial-params=WebBluetoothBlacklist.Group1:blacklist_additions/1111%3ae%2c180d%3ae%2c2222%3ae
(colon and comma escaped with %3a and %2c)

BUG=570121
==========

to

==========
bluetooth: Populate Web Bluetooth blacklist from variations:: parameter.

Enables rapid deployment of new blacklisted UUIDs for the
Web Bluetooth [blacklist] via field trial variation parameters.

[blacklist] https://webbluetoothcg.github.io/web-bluetooth/#the-gatt-blacklist

Includes a browsertest, but also tested manually with blacklist parms of:
180d:e                (heart rate excluded)
1111:e,180d:e,2222:e  (heart rate excluded)
1111:e,180d:w,2222:e  (heart rate write excluded, allows reading)
using command line parameters similar to:
--force-fieldtrials=WebBluetoothBlacklist/Group1
--force-fieldtrial-params=WebBluetoothBlacklist.Group1:blacklist_additions/1111%3ae%2c180d%3ae%2c2222%3ae
(colon and comma escaped with %3a and %2c)

BUG=570121

Committed: https://crrev.com/74250325d5c35950caa4a90b12045b41ff7f869a
Cr-Commit-Position: refs/heads/master@{#385644}
==========

[commit-bot: I haz the power, 2016-04-07 03:34:42]

Patchset 4 (id:??) landed as
https://crrev.com/74250325d5c35950caa4a90b12045b41ff7f869a
Cr-Commit-Position: refs/heads/master@{#385644}