Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issue 185863007: Try last resort on no-match in platformFallbackForCharacter on Android (Closed)

Created:
6 years, 9 months ago by Xianzhu
Modified:
6 years, 9 months ago
Reviewers:
dglazkov
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Try last resort on no-match in platformFallbackForCharacter on Android On Android, some locale-preferred fonts (e.g. DroidSansFallback.ttf for Chinese locale) doesn't contain all characters that the default locale system fonts contain. For characters that is missing in the font, fallback to the default locale system font, by calling getLastResortFallbackFont() in FontCache::platformFallbackForCharacter(). Also modified getLastResortFallbackFont() to prefer Skia default font instead of the hard-coded default font (sans) and to map also cursive and fantasy generic families. Combined similar code in FontCacheSkia.cpp. BUG=347121 TEST=FontCacheAndroid.platformFallbackForCharacter (will be enabled in another CL) R=dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168410

Patch Set 1 #

Patch Set 2 : Unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -29 lines) Patch
M Source/platform/fonts/AlternateFontFamily.h View 1 chunk +13 lines, -5 lines 0 comments Download
M Source/platform/fonts/android/FontCacheAndroid.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
A Source/platform/fonts/android/FontCacheAndroidTest.cpp View 1 1 chunk +29 lines, -0 lines 0 comments Download
M Source/platform/fonts/skia/FontCacheSkia.cpp View 3 chunks +3 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Xianzhu
6 years, 9 months ago (2014-03-04 02:25:34 UTC) #1
dglazkov
lgtm. How about a unit test?
6 years, 9 months ago (2014-03-04 05:08:07 UTC) #2
Xianzhu
On 2014/03/04 05:08:07, Dimitri Glazkov wrote: > lgtm. How about a unit test? Added. However, ...
6 years, 9 months ago (2014-03-04 18:17:17 UTC) #3
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 9 months ago (2014-03-04 18:17:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/185863007/20001
6 years, 9 months ago (2014-03-04 18:17:52 UTC) #5
Xianzhu
6 years, 9 months ago (2014-03-04 23:30:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r168410 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698