content/renderer/media/midi_dispatcher.cc - Issue 185863003: [Media] Add user gesture reporting for API calls to midi and media streams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/midi_dispatcher.cc

Issue 185863003: [Media] Add user gesture reporting for API calls to midi and media streams. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/chrome_midi_permission_context.cc ('K') | « content/renderer/media/media_stream_dispatcher.cc ('k') | content/shell/browser/shell_browser_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/midi_dispatcher.cc

diff --git a/content/renderer/media/midi_dispatcher.cc b/content/renderer/media/midi_dispatcher.cc

index a7c0679a449bce55c591999020f85eb0c4b36f1c..9576e4f33770b15b494e983aaf435f35ed3bf317 100644

--- a/content/renderer/media/midi_dispatcher.cc

+++ b/content/renderer/media/midi_dispatcher.cc

@@ -10,6 +10,7 @@

#include "content/renderer/render_view_impl.h"

#include "third_party/WebKit/public/web/WebMIDIPermissionRequest.h"

#include "third_party/WebKit/public/web/WebSecurityOrigin.h"

+#include "third_party/WebKit/public/web/WebUserGestureIndicator.h"

using blink::WebMIDIPermissionRequest;

using blink::WebSecurityOrigin;

@@ -38,7 +39,8 @@ void MidiDispatcher::requestSysExPermission(

WebSecurityOrigin security_origin = request.securityOrigin();

std::string origin = security_origin.toString().utf8();

GURL url(origin);

- Send(new MidiHostMsg_RequestSysExPermission(routing_id(), bridge_id, url));

+ Send(new MidiHostMsg_RequestSysExPermission(routing_id(), bridge_id, url,

+ blink::WebUserGestureIndicator::isProcessingUserGesture()));

}

void MidiDispatcher::cancelSysExPermissionRequest(