Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5442)

Unified Diff: chrome/browser/media/chrome_midi_permission_context.cc

Issue 185863003: [Media] Add user gesture reporting for API calls to midi and media streams. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/chrome_midi_permission_context.h ('k') | chrome/browser/policy/policy_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/chrome_midi_permission_context.cc
diff --git a/chrome/browser/media/chrome_midi_permission_context.cc b/chrome/browser/media/chrome_midi_permission_context.cc
index 7abcaff973f189f23e14df57dd57bb7872f3d88f..ebbc35e6835ba2dc0d359fc5a331f3515c9b7940 100644
--- a/chrome/browser/media/chrome_midi_permission_context.cc
+++ b/chrome/browser/media/chrome_midi_permission_context.cc
@@ -120,6 +120,7 @@ void ChromeMidiPermissionContext::RequestMidiSysExPermission(
int render_view_id,
int bridge_id,
const GURL& requesting_frame,
+ bool user_gesture,
const content::BrowserContext::MidiSysExPermissionCallback& callback) {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
DCHECK(!shutting_down_);
@@ -149,7 +150,8 @@ void ChromeMidiPermissionContext::RequestMidiSysExPermission(
return;
}
- DecidePermission(web_contents, id, requesting_frame, embedder, callback);
+ DecidePermission(web_contents, id, requesting_frame, embedder, user_gesture,
+ callback);
}
void ChromeMidiPermissionContext::CancelMidiSysExPermissionRequest(
@@ -166,6 +168,7 @@ void ChromeMidiPermissionContext::DecidePermission(
const PermissionRequestID& id,
const GURL& requesting_frame,
const GURL& embedder,
+ bool user_gesture,
Lei Zhang 2014/03/12 22:54:08 Why bother passing it to the internal method if it
Greg Billock 2014/03/24 21:19:42 The API change went in, so I'll just push it all t
const content::BrowserContext::MidiSysExPermissionCallback& callback) {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
« no previous file with comments | « chrome/browser/media/chrome_midi_permission_context.h ('k') | chrome/browser/policy/policy_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698