third_party/WebKit/Source/bindings/scripts/v8_interface.py - Issue 1858613002: bindings: Makes the window object be the inner global object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 1858613002: bindings: Makes the window object be the inner global object. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Synced. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp ('k') | third_party/WebKit/Source/bindings/templates/interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/v8_interface.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_interface.py b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

index bcfa35cc13b2e57c6c8be4891e61e12f976a0751..f82a0579ad54fb5d4924a42b4e0ddf908ce7ad9a 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_interface.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

@@ -164,7 +164,6 @@ def interface_context(interface):

'is_gc_type': True,

# FIXME: Remove 'EventTarget' special handling, http://crbug.com/383699

'has_access_check_callbacks': (is_check_security and

- interface.name != 'Window' and

interface.name != 'EventTarget'),

'has_custom_legacy_call_as_function': has_extended_attribute_value(interface, 'Custom', 'LegacyCallAsFunction'), # [Custom=LegacyCallAsFunction]

'has_partial_interface': len(interface.partial_interfaces) > 0,