Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WindowProxy.h

Issue 1858613002: bindings: Makes the window object be the inner global object. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Synced. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/WindowProxy.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h
index 3c59be5588c9ff48d6323cba7bd5298309bb6e0e..0765d0248a94b16ec8c1df89d0ba7088962a4463 100644
--- a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h
+++ b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h
@@ -105,8 +105,15 @@ private:
// Updates Activity Logger for the current context.
void updateActivityLogger();
+ // Creates a new v8::Context with the window wrapper object as the global
+ // object (aka the inner global). Note that the window wrapper and its
+ // prototype chain do not get fully initialized yet, e.g. the window
+ // wrapper is not yet associated with the native DOMWindow object.
void createContext();
- bool installDOMWindow();
+
+ // Associates the window wrapper and its prototype chain with the native
+ // DOMWindow object. Also does some more Window-specific initialization.
+ bool setupWindowPrototypeChain();
Member<Frame> m_frame;
v8::Isolate* m_isolate;

Powered by Google App Engine
This is Rietveld 408576698