third_party/WebKit/Source/core/frame/DOMWindow.cpp - Issue 1858613002: bindings: Makes the window object be the inner global object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.cpp

Issue 1858613002: bindings: Makes the window object be the inner global object. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/DOMWindow.cpp

diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.cpp b/third_party/WebKit/Source/core/frame/DOMWindow.cpp

index a02e3cc70b21c70290d911d236fb7b061dc26b05..ffa8170d3147124f05146baf11dd468b625720ba 100644

--- a/third_party/WebKit/Source/core/frame/DOMWindow.cpp

+++ b/third_party/WebKit/Source/core/frame/DOMWindow.cpp

@@ -44,7 +44,7 @@ DOMWindow::~DOMWindow()

v8::Local<v8::Object> DOMWindow::wrap(v8::Isolate*, v8::Local<v8::Object> creationContext)

{

// DOMWindow must never be wrapped with wrap method. The wrappers must be

- // created at WindowProxy::installDOMWindow().

+ // created at WindowProxy::createContext() and setupWindowPrototypeChain().

RELEASE_NOTREACHED();

return v8::Local<v8::Object>();

}