third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp - Issue 1858553002: Refactor StyleVariableData to fallback on root map for performance reasons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

Issue 1858553002: Refactor StyleVariableData to fallback on root map for performance reasons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h ('k') | third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

index 8dda6ecc25a71aa3b6a008ad0b9a5a08557ba4d0..c5c4b325e96315f69af58ad522f9e460d4fee4dc 100644

--- a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

+++ b/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp

@@ -29,6 +29,7 @@

#include "core/css/CSSPropertyMetadata.h"

#include "core/css/CSSSelector.h"

#include "core/css/CSSValuePool.h"

+#include "core/css/CSSVariableData.h"

#include "core/css/ComputedStyleCSSValueMapping.h"

#include "core/css/parser/CSSParser.h"

#include "core/css/parser/CSSVariableParser.h"

@@ -534,7 +535,7 @@ CSSValue* CSSComputedStyleDeclaration::getPropertyCSSValue(AtomicString customPr

return ComputedStyleCSSValueMapping::get(customPropertyName, *style);

}

-const HashMap<AtomicString, RefPtr<CSSVariableData>>* CSSComputedStyleDeclaration::getVariables() const

+std::unique_ptr<HashMap<AtomicString, RefPtr<CSSVariableData>>> CSSComputedStyleDeclaration::getVariables() const

{

const ComputedStyle* style = computeComputedStyle();

if (!style)