third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp - Issue 1858553002: Refactor StyleVariableData to fallback on root map for performance reasons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

Issue 1858553002: Refactor StyleVariableData to fallback on root map for performance reasons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp ('K') | « third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp ('k') | third_party/WebKit/Source/core/style/StyleVariableData.h » ('j') | third_party/WebKit/Source/core/style/StyleVariableData.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

index 879e1dd2dd46d85c190adfe1c4290dd56c754065..73e3e8b5ad2a05a0f45737b47446531dff50f6f7 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

@@ -1032,7 +1032,7 @@ void InspectorCSSAgent::getComputedStyleForNode(ErrorString* errorString, int no

if (!RuntimeEnabledFeatures::cssVariablesEnabled())

return;

- const HashMap<AtomicString, RefPtr<CSSVariableData>>* variables = computedStyleInfo->getVariables();

+ OwnPtr<HashMap<AtomicString, RefPtr<CSSVariableData>>> variables = computedStyleInfo->getVariables();

if (variables && !variables->isEmpty()) {

for (const auto& it : *variables) {