Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 1858553002: Refactor StyleVariableData to fallback on root map for performance reasons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Zack Rusin <zack@kde.org> 2 * Copyright (C) 2004 Zack Rusin <zack@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
4 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 4 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2011 Sencha, Inc. All rights reserved. 6 * Copyright (C) 2011 Sencha, Inc. All rights reserved.
7 * Copyright (C) 2015 Google Inc. All rights reserved. 7 * Copyright (C) 2015 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Lesser General Public 10 * modify it under the terms of the GNU Lesser General Public
(...skipping 1411 matching lines...) Expand 10 before | Expand all | Expand 10 after
1422 if (!variables) 1422 if (!variables)
1423 return nullptr; 1423 return nullptr;
1424 1424
1425 CSSVariableData* data = variables->getVariable(customPropertyName); 1425 CSSVariableData* data = variables->getVariable(customPropertyName);
1426 if (!data) 1426 if (!data)
1427 return nullptr; 1427 return nullptr;
1428 1428
1429 return CSSCustomPropertyDeclaration::create(customPropertyName, data); 1429 return CSSCustomPropertyDeclaration::create(customPropertyName, data);
1430 } 1430 }
1431 1431
1432 const HashMap<AtomicString, RefPtr<CSSVariableData>>* ComputedStyleCSSValueMappi ng::getVariables(const ComputedStyle& style) 1432 std::unique_ptr<HashMap<AtomicString, RefPtr<CSSVariableData>>> ComputedStyleCSS ValueMapping::getVariables(const ComputedStyle& style)
1433 { 1433 {
1434 StyleVariableData* variables = style.variables(); 1434 StyleVariableData* variables = style.variables();
1435 if (variables) 1435 if (variables)
1436 return variables->getVariables(); 1436 return variables->getVariables();
1437 return nullptr; 1437 return nullptr;
1438 } 1438 }
1439 1439
1440 CSSValue* ComputedStyleCSSValueMapping::get(CSSPropertyID propertyID, const Comp utedStyle& style, const LayoutObject* layoutObject, Node* styledNode, bool allow VisitedStyle) 1440 CSSValue* ComputedStyleCSSValueMapping::get(CSSPropertyID propertyID, const Comp utedStyle& style, const LayoutObject* layoutObject, Node* styledNode, bool allow VisitedStyle)
1441 { 1441 {
1442 const SVGComputedStyle& svgStyle = style.svgStyle(); 1442 const SVGComputedStyle& svgStyle = style.svgStyle();
(...skipping 1369 matching lines...) Expand 10 before | Expand all | Expand 10 after
2812 case CSSPropertyAll: 2812 case CSSPropertyAll:
2813 return nullptr; 2813 return nullptr;
2814 default: 2814 default:
2815 break; 2815 break;
2816 } 2816 }
2817 ASSERT_NOT_REACHED(); 2817 ASSERT_NOT_REACHED();
2818 return nullptr; 2818 return nullptr;
2819 } 2819 }
2820 2820
2821 } // namespace blink 2821 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698