Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 1858553002: Refactor StyleVariableData to fallback on root map for performance reasons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Zack Rusin <zack@kde.org> 2 * Copyright (C) 2004 Zack Rusin <zack@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
4 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 4 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2011 Sencha, Inc. All rights reserved. 6 * Copyright (C) 2011 Sencha, Inc. All rights reserved.
7 * Copyright (C) 2015 Google Inc. All rights reserved. 7 * Copyright (C) 2015 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Lesser General Public 10 * modify it under the terms of the GNU Lesser General Public
(...skipping 1357 matching lines...) Expand 10 before | Expand all | Expand 10 after
1368 if (!variables) 1368 if (!variables)
1369 return nullptr; 1369 return nullptr;
1370 1370
1371 CSSVariableData* data = variables->getVariable(customPropertyName); 1371 CSSVariableData* data = variables->getVariable(customPropertyName);
1372 if (!data) 1372 if (!data)
1373 return nullptr; 1373 return nullptr;
1374 1374
1375 return CSSCustomPropertyDeclaration::create(customPropertyName, data); 1375 return CSSCustomPropertyDeclaration::create(customPropertyName, data);
1376 } 1376 }
1377 1377
1378 const HashMap<AtomicString, RefPtr<CSSVariableData>>* ComputedStyleCSSValueMappi ng::getVariables(const ComputedStyle& style) 1378 PassOwnPtr<HashMap<AtomicString, RefPtr<CSSVariableData>>> ComputedStyleCSSValue Mapping::getVariables(const ComputedStyle& style)
1379 { 1379 {
1380 StyleVariableData* variables = style.variables(); 1380 StyleVariableData* variables = style.variables();
1381 if (variables) 1381 if (variables)
1382 return variables->getVariables(); 1382 return variables->getVariables();
1383 return nullptr; 1383 return nullptr;
1384 } 1384 }
1385 1385
1386 PassRefPtrWillBeRawPtr<CSSValue> ComputedStyleCSSValueMapping::get(CSSPropertyID propertyID, const ComputedStyle& style, const LayoutObject* layoutObject, Node* styledNode, bool allowVisitedStyle) 1386 PassRefPtrWillBeRawPtr<CSSValue> ComputedStyleCSSValueMapping::get(CSSPropertyID propertyID, const ComputedStyle& style, const LayoutObject* layoutObject, Node* styledNode, bool allowVisitedStyle)
1387 { 1387 {
1388 const SVGComputedStyle& svgStyle = style.svgStyle(); 1388 const SVGComputedStyle& svgStyle = style.svgStyle();
(...skipping 1365 matching lines...) Expand 10 before | Expand all | Expand 10 after
2754 case CSSPropertyAll: 2754 case CSSPropertyAll:
2755 return nullptr; 2755 return nullptr;
2756 default: 2756 default:
2757 break; 2757 break;
2758 } 2758 }
2759 ASSERT_NOT_REACHED(); 2759 ASSERT_NOT_REACHED();
2760 return nullptr; 2760 return nullptr;
2761 } 2761 }
2762 2762
2763 } // namespace blink 2763 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698