Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 1858533002: Introduce WebCachePolicy to merge cache policy enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: self review, minor fixes Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
index b7a7bb95a670162c1fa300bb75ade3ab4c0fe84d..0919502b098769159fa56ccb7b20e06aca4f23ed 100644
--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
@@ -1274,16 +1274,13 @@ TEST_F(WebViewTest, BackForwardRestoreScroll)
// Go back, then forward, then back again.
mainFrameLocal->loader().load(
- FrameLoadRequest(nullptr, FrameLoader::resourceRequestFromHistoryItem(
- item1.get(), UseProtocolCachePolicy)),
+ FrameLoadRequest(nullptr, FrameLoader::resourceRequestFromHistoryItem(item1.get(), WebCachePolicy::UseProtocolCachePolicy)),
FrameLoadTypeBackForward, item1.get(), HistorySameDocumentLoad);
mainFrameLocal->loader().load(
- FrameLoadRequest(nullptr, FrameLoader::resourceRequestFromHistoryItem(
- item2.get(), UseProtocolCachePolicy)),
+ FrameLoadRequest(nullptr, FrameLoader::resourceRequestFromHistoryItem(item2.get(), WebCachePolicy::UseProtocolCachePolicy)),
FrameLoadTypeBackForward, item2.get(), HistorySameDocumentLoad);
mainFrameLocal->loader().load(
- FrameLoadRequest(nullptr, FrameLoader::resourceRequestFromHistoryItem(
- item1.get(), UseProtocolCachePolicy)),
+ FrameLoadRequest(nullptr, FrameLoader::resourceRequestFromHistoryItem(item1.get(), WebCachePolicy::UseProtocolCachePolicy)),
FrameLoadTypeBackForward, item1.get(), HistorySameDocumentLoad);
// Click a different anchor
@@ -1292,12 +1289,10 @@ TEST_F(WebViewTest, BackForwardRestoreScroll)
// Go back, then forward. The scroll position should be properly set on the forward navigation.
mainFrameLocal->loader().load(
- FrameLoadRequest(nullptr, FrameLoader::resourceRequestFromHistoryItem(
- item1.get(), UseProtocolCachePolicy)),
+ FrameLoadRequest(nullptr, FrameLoader::resourceRequestFromHistoryItem(item1.get(), WebCachePolicy::UseProtocolCachePolicy)),
FrameLoadTypeBackForward, item1.get(), HistorySameDocumentLoad);
mainFrameLocal->loader().load(
- FrameLoadRequest(nullptr, FrameLoader::resourceRequestFromHistoryItem(
- item3.get(), UseProtocolCachePolicy)),
+ FrameLoadRequest(nullptr, FrameLoader::resourceRequestFromHistoryItem(item3.get(), WebCachePolicy::UseProtocolCachePolicy)),
FrameLoadTypeBackForward, item3.get(), HistorySameDocumentLoad);
EXPECT_EQ(0, webViewImpl->mainFrame()->scrollOffset().width);
EXPECT_GT(webViewImpl->mainFrame()->scrollOffset().height, 2000);

Powered by Google App Engine
This is Rietveld 408576698