Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 1858533002: Introduce WebCachePolicy to merge cache policy enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: self review, minor fixes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index d7c1ff6cae32495ba08f62378e1fd64a76cfd300..22362ae20ac09ad07a90bafea2f4199bf14e0d51 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -891,8 +891,7 @@ void WebLocalFrameImpl::loadRequest(const WebURLRequest& request)
load(request, WebFrameLoadType::Standard, WebHistoryItem(), WebHistoryDifferentDocumentLoad, false);
}
-void WebLocalFrameImpl::loadHistoryItem(const WebHistoryItem& item, WebHistoryLoadType loadType,
- WebURLRequest::CachePolicy cachePolicy)
+void WebLocalFrameImpl::loadHistoryItem(const WebHistoryItem& item, WebHistoryLoadType loadType, WebCachePolicy cachePolicy)
{
// TODO(clamy): Remove this function once RenderFrame calls load for all
// requests.
@@ -1596,7 +1595,7 @@ RawPtr<LocalFrame> WebLocalFrameImpl::createChildFrame(const FrameLoadRequest& r
FrameLoadType loadType = FrameLoadTypeStandard;
if (childItem) {
newRequest = FrameLoadRequest(request.originDocument(),
- FrameLoader::resourceRequestFromHistoryItem(childItem.get(), UseProtocolCachePolicy));
+ FrameLoader::resourceRequestFromHistoryItem(childItem.get(), WebCachePolicy::UseProtocolCachePolicy));
loadType = FrameLoadTypeInitialHistoryLoad;
}
webframeChild->frame()->loader().load(newRequest, loadType, childItem.get());
@@ -1895,12 +1894,11 @@ void WebLocalFrameImpl::sendPings(const WebNode& contextNode, const WebURL& dest
toHTMLAnchorElement(anchor)->sendPings(destinationURL);
}
-WebURLRequest WebLocalFrameImpl::requestFromHistoryItem(const WebHistoryItem& item,
- WebURLRequest::CachePolicy cachePolicy) const
+WebURLRequest WebLocalFrameImpl::requestFromHistoryItem(const WebHistoryItem& item, WebCachePolicy cachePolicy) const
{
RawPtr<HistoryItem> historyItem = RawPtr<HistoryItem>(item);
ResourceRequest request = FrameLoader::resourceRequestFromHistoryItem(
- historyItem.get(), static_cast<ResourceRequestCachePolicy>(cachePolicy));
+ historyItem.get(), cachePolicy);
return WrappedResourceRequest(request);
}

Powered by Google App Engine
This is Rietveld 408576698