Chromium Code Reviews

Issue 1858523002: When building chrome/win on non-win, make sure is_win is true while running grit. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When building chrome/win on non-win, make sure is_win is true while running grit. BUG=495204 Committed: https://crrev.com/6c583d0ab4453cd43507d39aff687ee436f03b85 Cr-Commit-Position: refs/heads/master@{#384894}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+32 lines, -7 lines)
M tools/grit/grit_rule.gni View 2 chunks +32 lines, -7 lines 1 comment

Messages

Total messages: 8 (3 generated)
Nico
https://codereview.chromium.org/1858523002/diff/1/tools/grit/grit_rule.gni File tools/grit/grit_rule.gni (right): https://codereview.chromium.org/1858523002/diff/1/tools/grit/grit_rule.gni#newcode203 tools/grit/grit_rule.gni:203: ] I wish `gn format` allowed ` grit_defines += ...
4 years, 8 months ago (2016-04-04 01:36:08 UTC) #2
brettw
lgtm
4 years, 8 months ago (2016-04-04 05:01:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858523002/1
4 years, 8 months ago (2016-04-04 13:18:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 13:23:03 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 13:24:56 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6c583d0ab4453cd43507d39aff687ee436f03b85
Cr-Commit-Position: refs/heads/master@{#384894}

Powered by Google App Engine