Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1858493002: convert //chrome_elf to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by Mostyn Bramley-Moore
Modified:
4 years, 8 months ago
Reviewers:
Cait (Slow)
CC:
chromium-reviews, caitkp+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

convert //chrome_elf to std::unique_ptr BUG=554298 Committed: https://crrev.com/1795070c67cd08f5c5437b4e0d3ae6e5d3e5fd13 Cr-Commit-Position: refs/heads/master@{#384925}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome_elf/blacklist/test/blacklist_test.cc View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858493002/1
4 years, 8 months ago (2016-04-03 19:59:16 UTC) #2
Mostyn Bramley-Moore
@Cait: please take a look.
4 years, 8 months ago (2016-04-03 20:24:36 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-03 20:32:21 UTC) #6
Cait (Slow)
lgtm
4 years, 8 months ago (2016-04-04 14:25:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858493002/1
4 years, 8 months ago (2016-04-04 16:26:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 16:32:52 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 16:34:18 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1795070c67cd08f5c5437b4e0d3ae6e5d3e5fd13
Cr-Commit-Position: refs/heads/master@{#384925}

Powered by Google App Engine
This is Rietveld 408576698