Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1858473002:
Fire visibilitychange on page unloading when experimental flag is on (Closed)
|
Created:
4 years, 8 months ago by kinuko Modified:
4 years, 8 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
blink-reviews, chromium-reviews, kinuko+watch Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFire visibilitychange on page unloading when experimental flag is on
(So that more people can easily start testing this)
BUG=554834
Committed: https://crrev.com/26f8cbe616e35ac6839970e9b52eb35405f61685
Cr-Commit-Position: refs/heads/master@{#385106}
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
The CQ bit was checked by kinuko@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858473002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fire visibilitychange on page unloading when experimental flag is on BUG= ========== to ========== Fire visibilitychange on page unloading when experimental flag is on (So that more people can easily start testing this) BUG=594049 ==========
kinuko@chromium.org changed reviewers: + jochen@chromium.org
Description was changed from ========== Fire visibilitychange on page unloading when experimental flag is on (So that more people can easily start testing this) BUG=594049 ========== to ========== Fire visibilitychange on page unloading when experimental flag is on (So that more people can easily start testing this) BUG=554834 ==========
jochen: could you stamp on this one-line change?
can you add a link to the intent to experiment to the CL description?
ah, sorry, you don't want to start an experiment, just change the feature state lgtm
yep. thanks!
The CQ bit was checked by kinuko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858473002/1
Message was sent while issue was closed.
Description was changed from ========== Fire visibilitychange on page unloading when experimental flag is on (So that more people can easily start testing this) BUG=554834 ========== to ========== Fire visibilitychange on page unloading when experimental flag is on (So that more people can easily start testing this) BUG=554834 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fire visibilitychange on page unloading when experimental flag is on (So that more people can easily start testing this) BUG=554834 ========== to ========== Fire visibilitychange on page unloading when experimental flag is on (So that more people can easily start testing this) BUG=554834 Committed: https://crrev.com/26f8cbe616e35ac6839970e9b52eb35405f61685 Cr-Commit-Position: refs/heads/master@{#385106} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/26f8cbe616e35ac6839970e9b52eb35405f61685 Cr-Commit-Position: refs/heads/master@{#385106} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
