Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Unified Diff: build/common.gypi

Issue 1858423002: Fix C4334 (32-bit shift converted to 64-bit) warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing obsolete comment and pointless '1' Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 871daa551a522b65f0a45dbe79300474682e86ef..592b68b0fb9de0d557675fc30112d6a52ef1a974 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -5717,10 +5717,11 @@
# 2015 64-bit warning for integer to larger pointer
4312,
- # TODO(brucedawson): http://crbug.com/593448 4334 is a 'suspicious
- # shift' warning and 4595 is an 'illegal inline operator new' warning
- # Both are new in VS 2015 Update 2 and can safely be deferred for now.
- 4334, 4595,
+ # TODO(brucedawson): http://crbug.com/593448 - C4595 is an 'illegal
+ # inline operator new' warning that is new in VS 2015 Update 2.
+ # This is equivalent to clang's no-inline-new-delete warning.
+ # See http://bugs.icu-project.org/trac/ticket/11122
+ 4595,
],
'msvs_settings': {
'VCCLCompilerTool': {
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698