Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1858423002: Fix C4334 (32-bit shift converted to 64-bit) warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing obsolete comment and pointless '1' Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | media/filters/vp8_parser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 10
(...skipping 774 matching lines...) Expand 10 before | Expand all | Expand 10 after
785 # VC++ 2015 changes 32-bit size_t truncation warnings from 4244 to 4267. 785 # VC++ 2015 changes 32-bit size_t truncation warnings from 4244 to 4267.
786 # Example: short TruncTest(size_t x) { return x; } 786 # Example: short TruncTest(size_t x) { return x; }
787 # Since we disable 4244 we need to disable 4267 during migration. 787 # Since we disable 4244 we need to disable 4267 during migration.
788 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. 788 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
789 "/wd4267", 789 "/wd4267",
790 790
791 # C4312 is a VS 2015 64-bit warning for integer to larger pointer. 791 # C4312 is a VS 2015 64-bit warning for integer to larger pointer.
792 # TODO(brucedawson): fix warnings, crbug.com/554200 792 # TODO(brucedawson): fix warnings, crbug.com/554200
793 "/wd4312", 793 "/wd4312",
794 794
795 # TODO(brucedawson): http://crbug.com/593448 4334 is a 'suspicious 795 # TODO(brucedawson): http://crbug.com/593448 - C4595 is an 'illegal
796 # shift' warning and 4595 is an 'illegal inline operator new' warning 796 # inline operator new' warning that is new in VS 2015 Update 2.
797 # Both are new in VS 2015 Update 2 and can safely be deferred for now. 797 # This is equivalent to clang's no-inline-new-delete warning.
798 "/wd4334", 798 # See http://bugs.icu-project.org/trac/ticket/11122
799 "/wd4595", 799 "/wd4595",
800 ] 800 ]
801 } 801 }
802 802
803 # VS xtree header file needs to be patched or 4702 (unreachable code 803 # VS xtree header file needs to be patched or 4702 (unreachable code
804 # warning) is reported if _HAS_EXCEPTIONS=0. Disable the warning if xtree is 804 # warning) is reported if _HAS_EXCEPTIONS=0. Disable the warning if xtree is
805 # not patched. 805 # not patched.
806 if (!msvs_xtree_patched && 806 if (!msvs_xtree_patched &&
807 exec_script("../../win_is_xtree_patched.py", [], "value") == 0) { 807 exec_script("../../win_is_xtree_patched.py", [], "value") == 0) {
808 cflags += [ "/wd4702" ] # Unreachable code. 808 cflags += [ "/wd4702" ] # Unreachable code.
(...skipping 537 matching lines...) Expand 10 before | Expand all | Expand 10 after
1346 1346
1347 if (is_ios || is_mac) { 1347 if (is_ios || is_mac) {
1348 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1348 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1349 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1349 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1350 config("enable_arc") { 1350 config("enable_arc") {
1351 common_flags = [ "-fobjc-arc" ] 1351 common_flags = [ "-fobjc-arc" ]
1352 cflags_objc = common_flags 1352 cflags_objc = common_flags
1353 cflags_objcc = common_flags 1353 cflags_objcc = common_flags
1354 } 1354 }
1355 } 1355 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | media/filters/vp8_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698