Issue 18584007: Bugfix: AllocationSite objects need to be walkable by the heap snapshot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18584007: Bugfix: AllocationSite objects need to be walkable by the heap snapshot (Closed)

Created:
7 years, 5 months ago by mvstanton

Modified:
7 years, 5 months ago

Reviewers:
Toon Verwaest, Michael Achenbach

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Bugfix: AllocationSite objects need to be walkable by the heap snapshot generator. BUG= R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15575

Patch Set 2 : Changed approach somewhat #

Patch Set 3 : Nit fixin' #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -2 lines)			Patch
M	src/heap-snapshot-generator.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/heap-snapshot-generator.cc	View	1 2	2 chunks	+10 lines, -2 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	1	1 chunk	+50 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

LGTM with nit https://codereview.chromium.org/18584007/diff/1/src/heap-snapshot-generator.cc File src/heap-snapshot-generator.cc (right): https://codereview.chromium.org/18584007/diff/1/src/heap-snapshot-generator.cc#newcode958 src/heap-snapshot-generator.cc:958: ExtractPropertyCellReferences( nit: (unrelated) make one-liner

7 years, 5 months ago (2013-07-09 12:53:10 UTC) #2

mvstanton

Committed patchset #3 manually as r15575 (presubmit successful).

7 years, 5 months ago (2013-07-09 14:17:09 UTC) #3