Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: base/android/java_thread.h

Issue 18584006: Making a way to create thread with a Java Looper for Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Style fixes, and make the waitable event a stack variable Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/java_thread.h
diff --git a/base/android/java_thread.h b/base/android/java_thread.h
new file mode 100644
index 0000000000000000000000000000000000000000..0ab8191e8940fb36df032964ff8606a809f01deb
--- /dev/null
+++ b/base/android/java_thread.h
@@ -0,0 +1,51 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BASE_THREADING_JAVA_THREAD_H_
+#define BASE_THREADING_JAVA_THREAD_H_
+
+#include <jni.h>
+
+#include "base/android/scoped_java_ref.h"
+#include "base/memory/scoped_ptr.h"
+
+namespace base {
+
+class MessageLoop;
+class WaitableEvent;
+
+namespace android {
+
+// A Java Thread with a native message loop. To run tasks, post them
+// to the message loop and they will be scheduled along Java tasks
+// on the thread.
+// This is useful for callbacks where the receiver expects a thread
+// with a prepared Looper.
+class JavaThread {
+ public:
+ JavaThread(const char* name);
+ virtual ~JavaThread() {}
+
+ base::MessageLoop* message_loop() const { return message_loop_.get(); }
+ void Start();
+ void Stop();
+
+ // Called from java on the newly created thread.
+ // Start() will not return before this methods has finished.
+ void InitializeThread(JNIEnv* env, jobject obj, jint event);
joth 2013/07/17 16:29:18 guess this can be private
Kristian Monsen 2013/07/17 21:02:37 Done.
Kristian Monsen 2013/07/17 21:54:40 Actually it cannot be private since it is called b
+
+ static bool RegisterBindings(JNIEnv* env);
+
+ private:
+ scoped_ptr<base::MessageLoop> message_loop_;
+ ScopedJavaGlobalRef<jobject> java_thread_;
+
+ bool started_;
+};
+
+} // namespace android
+
joth 2013/07/17 16:29:18 uber nit: no blank line here (nor in the .cc, nor
Kristian Monsen 2013/07/17 21:02:37 Done. You mean in general for closing two namespac
+} // namespace base
+
+#endif // BASE_THREADING_JAVA_THREAD_H_

Powered by Google App Engine
This is Rietveld 408576698