Making a way to create thread with a Java Looper for Android

content/browser/renderer_host/java/java_bridge_dispatcher_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/java/java_bridge_dispatcher_host.h"
 
 #include "base/bind.h"
 #include "base/lazy_instance.h"
-#include "base/threading/thread.h"
 #include "content/browser/renderer_host/java/java_bridge_channel_host.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/child/child_process.h"
 #include "content/child/npobject_stub.h"
 #include "content/child/npobject_util.h"  // For CreateNPVariantParam()
 #include "content/common/java_bridge_messages.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_process_host.h"
 #include "third_party/WebKit/public/web/WebBindings.h"
 
+#ifdef ANDROID

[joth, 2013/07/10 20:33:48]

#if defined(OS_ANDROID)

although this entire file is only built on android anyway, so I'd just skip
using ifdef here.
(you could rename the /java/ folder to android if you really want, and greatly
simplify the .gypi. Separate patch if you want to do that though).

[Kristian Monsen, 2013/07/16 21:54:41]

Will remove the #ifdef after renaming the folder to android.

+#include "base/android/java_thread.h"
+#else
+#include "base/threading/thread.h"
+#endif
+
+
+#ifdef ANDROID
+#define THREAD base::android::JavaThread
+#else
+#define THREAD base::Thread

[joth, 2013/07/10 20:33:48]

typedef is nicer (but I'd not use the ifdef at all, as per comment above. this
else cases are dead code)

[Kristian Monsen, 2013/07/16 21:54:41]

Done.

+#endif
+
 namespace content {
 
 namespace {
-class JavaBridgeThread : public base::Thread {
+class JavaBridgeThread : public THREAD {
  public:
-  JavaBridgeThread() : base::Thread("JavaBridge") {
+  JavaBridgeThread() : THREAD("JavaBridge") {
     Start();
   }
   virtual ~JavaBridgeThread() {
     Stop();
   }
 };
 
 void CleanUpStubs(const std::vector<base::WeakPtr<NPObjectStub> > & stubs) {
   for (size_t i = 0; i < stubs.size(); ++i) {
     if (stubs[i]) {
@@ skipping 122 matching lines @@
   // functionality. The page URL is also not required.
   stubs_.push_back((new NPObjectStub(
       object, channel_.get(), route_id, 0, GURL()))->AsWeakPtr());
 
   // The NPObjectStub takes a reference to the NPObject. Release the ref added
   // in CreateNPVariantParam().
   WebKit::WebBindings::releaseObject(object);
 }
 
 }  // namespace content