Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1858353002: Update SkMatrixImageFilter to sk_sp (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : update to ToT #

Patch Set 4 : update to ToT #

Patch Set 5 : Fix fuzz #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -64 lines) Patch
M fuzz/FilterFuzz.cpp View 1 2 3 4 1 chunk +4 lines, -6 lines 0 comments Download
M gm/filterfastbounds.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/imagefilters.cpp View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M gm/imagefiltersclipped.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imagefiltersscaled.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imagefiltersstroked.cpp View 2 chunks +6 lines, -10 lines 0 comments Download
M gm/imageresizetiled.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/matriximagefilter.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M gm/resizeimagefilter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M include/core/SkImageFilter.h View 1 chunk +10 lines, -2 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 2 3 1 chunk +4 lines, -6 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/core/SkMatrixImageFilter.h View 1 chunk +12 lines, -4 lines 0 comments Download
M src/core/SkMatrixImageFilter.cpp View 2 chunks +9 lines, -7 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 2 3 4 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
robertphillips
4 years, 8 months ago (2016-04-05 18:54:37 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858353002/20001
4 years, 8 months ago (2016-04-05 18:54:45 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/1714) Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot on ...
4 years, 8 months ago (2016-04-05 18:55:55 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858353002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858353002/40001
4 years, 8 months ago (2016-04-05 19:13:54 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 19:23:25 UTC) #12
f(malita)
lgtm
4 years, 8 months ago (2016-04-05 19:36:54 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858353002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858353002/60001
4 years, 8 months ago (2016-04-05 19:53:26 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/7625)
4 years, 8 months ago (2016-04-05 19:54:57 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858353002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858353002/80001
4 years, 8 months ago (2016-04-05 21:15:45 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 21:28:44 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858353002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858353002/80001
4 years, 8 months ago (2016-04-05 22:08:05 UTC) #24
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 22:09:05 UTC) #26
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/ae8c933ca89315c1256bcf23749b5ee5cbc0d53c

Powered by Google App Engine
This is Rietveld 408576698