Give the clang upload bots shorter names.

Give the clang upload bots shorter names.

Currently, git fails to delete files on these bots because path names
are too long (on Windows), and the bot / checkout name is part of the
path.  Our other bots don't have this problem, so try giving the bot
a shorter name (and rename the non-Win bots for consistency).

BUG=600465
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299707

[Nico, 2016-04-05 18:09:39]

thakis@chromium.org changed reviewers:
+ dpranke@chromium.org, krasin@chromium.org

[Nico, 2016-04-05 18:09:39]

Somewhat speculative, but our other tot bots don't have this problem.

(Why also change "clang_upload" to "upload_clang"? Because the trybot is called
"win_clang" and I'm more likely to accidentally turn that into
"win_clang_upload" than "win_upload_clang")

This will need src-side changes too, but since these are on-demand bots I think
just landing this and then changing src is ok.

[Dirk Pranke, 2016-04-05 18:15:20]

lgtm

[krasin, 2016-04-05 18:15:59]

krasin@google.com changed reviewers:
+ krasin@google.com

[krasin, 2016-04-05 18:16:00]

https://codereview.chromium.org/1858343002/diff/20001/masters/master.tryserve...
File masters/master.tryserver.chromium.linux/master.cfg (right):

https://codereview.chromium.org/1858343002/diff/20001/masters/master.tryserve...
masters/master.tryserver.chromium.linux/master.cfg:227: 'factory':
m_annotator.BaseFactory('chromium_upload_clang'),
This line looks suspicious, because the rest of the CL is just about renaming
bots, and you don't rename the factory anywhere. Can you please double check?

[Nico, 2016-04-05 18:20:19]

https://codereview.chromium.org/1858343002/diff/20001/masters/master.tryserve...
File masters/master.tryserver.chromium.linux/master.cfg (right):

https://codereview.chromium.org/1858343002/diff/20001/masters/master.tryserve...
masters/master.tryserver.chromium.linux/master.cfg:227: 'factory':
m_annotator.BaseFactory('chromium_upload_clang'),
On 2016/04/05 18:16:00, krasin wrote:
> This line looks suspicious, because the rest of the CL is just about renaming
> bots, and you don't rename the factory anywhere. Can you please double check?

Oh, you're right, good catch! Done, renamed the factory too.

[krasin, 2016-04-05 19:56:11]

LGTM.

Sorry for a delay in the review.

[Nico, 2016-04-05 20:10:18]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-04-05 20:10:18]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1858343002/#ps60001
(title: ".")

[commit-bot: I haz the power, 2016-04-05 20:10:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858343002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858343002/60001

[commit-bot: I haz the power, 2016-04-05 20:14:21]

Description was changed from

==========
Give the clang upload bots shorter names.

Currently, git fails to delete files on these bots because path names
are too long (on Windows), and the bot / checkout name is part of the
path.  Our other bots don't have this problem, so try giving the bot
a shorter name (and rename the non-Win bots for consistency).

BUG=600465
==========

to

==========
Give the clang upload bots shorter names.

Currently, git fails to delete files on these bots because path names
are too long (on Windows), and the bot / checkout name is part of the
path.  Our other bots don't have this problem, so try giving the bot
a shorter name (and rename the non-Win bots for consistency).

BUG=600465

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299707
==========

[commit-bot: I haz the power, 2016-04-05 20:14:22]

Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299707