Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: runtime/vm/debugger_api_impl_test.cc

Issue 1858283002: Initial SIMDBC interpreter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: cleanup Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/debugger_api_impl_test.cc
diff --git a/runtime/vm/debugger_api_impl_test.cc b/runtime/vm/debugger_api_impl_test.cc
index 0be2d29e1dc71a512a2af44a6a241fe31f692158..58de09fc31a81d8bc9b70b166dda8900ccd208d7 100644
--- a/runtime/vm/debugger_api_impl_test.cc
+++ b/runtime/vm/debugger_api_impl_test.cc
@@ -282,8 +282,13 @@ static void VerifyStackTrace(Dart_StackTrace trace,
res = Dart_ActivationFrameGetFramePointer(frame, &frame_pointer);
EXPECT_TRUE(res);
if (i > 0) {
+#if !defined(TARGET_ARCH_DBC)
// We expect the stack to grow from high to low addresses.
EXPECT_GT(frame_pointer, last_frame_pointer);
+#else
+ // On DBC stack grows upwards from low to high addresses.
+ EXPECT_LT(frame_pointer, last_frame_pointer);
+#endif
}
last_frame_pointer = frame_pointer;
if (i < expected_frames) {
@@ -493,11 +498,13 @@ TEST_CASE(Debug_InspectStack_NotOptimized) {
}
+#if !defined(TARGET_ARCH_DBC)
zra 2016/04/08 22:37:35 enable and mark in status file?
Vyacheslav Egorov (Google) 2016/04/11 10:49:10 Done.
TEST_CASE(Debug_InspectStack_Optimized) {
// Ensure code gets optimized.
FLAG_background_compilation = false;
InspectStackTest(true);
}
+#endif
static void InspectStackWithClosureTest(bool optimize) {
@@ -591,11 +598,13 @@ TEST_CASE(Debug_InspectStackWithClosure_NotOptimized) {
}
+#if !defined(TARGET_ARCH_DBC)
zra 2016/04/08 22:37:34 ditto
Vyacheslav Egorov (Google) 2016/04/11 10:49:10 Done.
TEST_CASE(Debug_InspectStackWithClosure_Optimized) {
// Ensure code gets optimized.
FLAG_background_compilation = false;
InspectStackWithClosureTest(true);
}
+#endif
void TestStepOutHandler(Dart_IsolateId isolate_id,

Powered by Google App Engine
This is Rietveld 408576698