Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2270)

Unified Diff: runtime/vm/locations.h

Issue 1858283002: Initial SIMDBC interpreter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/locations.h
diff --git a/runtime/vm/locations.h b/runtime/vm/locations.h
index 963c4b49a7f96f962db8aaa176259cfe3a880bab..1cce78ac81e57a90ce9561761919d645837ed5d6 100644
--- a/runtime/vm/locations.h
+++ b/runtime/vm/locations.h
@@ -341,8 +341,10 @@ class Location : public ValueObject {
return IsStackSlot() || IsDoubleStackSlot() || IsQuadStackSlot();
}
+#if !defined(TARGET_ARCH_DBC)
zra 2016/04/14 18:27:49 Why?
Vyacheslav Egorov (Google) 2016/04/18 15:56:42 There was a comment in the CC file explaining. Cop
// Return a memory operand for stack slot locations.
Address ToStackSlotAddress() const;
+#endif
// Returns the offset from the frame pointer for stack slot locations.
intptr_t ToStackSlotOffset() const;
@@ -650,9 +652,13 @@ class LocationSummary : public ZoneAllocated {
void set_out(intptr_t index, Location loc) {
ASSERT(index == 0);
+ // DBC calls are different from call on other architectures so this
+ // assert doesn't make sense.
+#if !defined(TARGET_ARCH_DBC)
ASSERT(!always_calls() ||
(loc.IsMachineRegister() || loc.IsInvalid() ||
loc.IsPairLocation()));
+#endif
output_location_ = loc;
}

Powered by Google App Engine
This is Rietveld 408576698