Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1858263002: [asm.js] Fix typing bug for non-literals in heap access. (Closed)

Created:
4 years, 8 months ago by titzer
Modified:
4 years, 8 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[asm.js] Fix typing bug for non-literals in heap access. R=bradnelson@chromium.org BUG=chromium:599825 LOG=Y Committed: https://crrev.com/77a8c2ea860027f551eaf6dd50a1dff6c0ed204f Cr-Commit-Position: refs/heads/master@{#35273}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M src/typing-asm.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-599825.js View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
titzer
4 years, 8 months ago (2016-04-05 15:18:28 UTC) #1
bradnelson
Otherwise, lgtm https://codereview.chromium.org/1858263002/diff/1/test/mjsunit/regress/regress-599825.js File test/mjsunit/regress/regress-599825.js (right): https://codereview.chromium.org/1858263002/diff/1/test/mjsunit/regress/regress-599825.js#newcode12 test/mjsunit/regress/regress-599825.js:12: __v_30[__v_27 >> __v_2] = ((__v_30[-1073741825]|-10) + 2) ...
4 years, 8 months ago (2016-04-05 16:07:18 UTC) #2
titzer
https://codereview.chromium.org/1858263002/diff/1/test/mjsunit/regress/regress-599825.js File test/mjsunit/regress/regress-599825.js (right): https://codereview.chromium.org/1858263002/diff/1/test/mjsunit/regress/regress-599825.js#newcode12 test/mjsunit/regress/regress-599825.js:12: __v_30[__v_27 >> __v_2] = ((__v_30[-1073741825]|-10) + 2) | 0; ...
4 years, 8 months ago (2016-04-05 16:58:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858263002/20001
4 years, 8 months ago (2016-04-05 16:58:55 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 17:23:13 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 17:24:09 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/77a8c2ea860027f551eaf6dd50a1dff6c0ed204f
Cr-Commit-Position: refs/heads/master@{#35273}

Powered by Google App Engine
This is Rietveld 408576698