V8: Move x87 builders to new master.

V8: Move x87 builders to new master.

BUG=485955
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299703

[Michael Achenbach, 2016-04-05 14:05:57]

Description was changed from

==========
V8: Move x87 builders to new master.

BUG=
==========

to

==========
V8: Move x87 builders to new master.

BUG=485955
==========

[Michael Achenbach, 2016-04-05 14:06:02]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 14:06:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858233002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858233002/1

[commit-bot: I haz the power, 2016-04-05 14:14:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 14:14:22]

Dry run: Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[Michael Achenbach, 2016-04-05 14:21:11]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 14:21:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858233002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858233002/20001

[Michael Achenbach, 2016-04-05 14:27:39]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 14:27:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858233002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858233002/40001

[commit-bot: I haz the power, 2016-04-05 14:35:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 14:35:44]

Dry run: Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[Michael Achenbach, 2016-04-05 14:41:02]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 14:41:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858233002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858233002/60001

[commit-bot: I haz the power, 2016-04-05 14:45:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 14:45:16]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-04-05 14:50:02]

machenbach@chromium.org changed reviewers:
+ kjellander@chromium.org, sergiyb@chromium.org

[Michael Achenbach, 2016-04-05 14:50:04]

PTAL

https://codereview.chromium.org/1858233002/diff/60001/masters/master.client.v...
File masters/master.client.v8/mail_notifier_cfg.py (left):

https://codereview.chromium.org/1858233002/diff/60001/masters/master.client.v...
masters/master.client.v8/mail_notifier_cfg.py:64: x87_categories_steps = {'x87':
['runhooks', 'compile', 'Unittests', 'Check']}
Removing Unittests when moving the code. The step doesn't exist anymore. Was
merged into Check a while ago.

https://codereview.chromium.org/1858233002/diff/60001/masters/master.client.v...
File masters/master.client.v8/slaves.cfg (left):

https://codereview.chromium.org/1858233002/diff/60001/masters/master.client.v...
masters/master.client.v8/slaves.cfg:336: for vm in [3, 4, 5, 26]:
Reserving 26 for a new s390 bot in a follow up CL to avoid yet another master
restart.

https://codereview.chromium.org/1858233002/diff/60001/scripts/slave/bot_updat...
File scripts/slave/bot_update.py (right):

https://codereview.chromium.org/1858233002/diff/60001/scripts/slave/bot_updat...
scripts/slave/bot_update.py:274: 'client.v8.ports',
Wonder what this file is still doing here. The same is in depot tools as a
resource. The change there was necessary for this to work:
https://codereview.chromium.org/1858193002/

I change it here too for consistency.

[Sergiy Byelozyorov, 2016-04-05 15:04:09]

lgtm w/ question

https://codereview.chromium.org/1858233002/diff/60001/masters/master.client.v...
File masters/master.client.v8/mail_notifier_cfg.py (left):

https://codereview.chromium.org/1858233002/diff/60001/masters/master.client.v...
masters/master.client.v8/mail_notifier_cfg.py:64: x87_categories_steps = {'x87':
['runhooks', 'compile', 'Unittests', 'Check']}
On 2016/04/05 14:50:03, Michael Achenbach wrote:
> Removing Unittests when moving the code. The step doesn't exist anymore. Was
> merged into Check a while ago.

Acknowledged.

https://codereview.chromium.org/1858233002/diff/60001/masters/master.client.v...
File masters/master.client.v8/slaves.cfg (left):

https://codereview.chromium.org/1858233002/diff/60001/masters/master.client.v...
masters/master.client.v8/slaves.cfg:336: for vm in [3, 4, 5, 26]:
On 2016/04/05 14:50:03, Michael Achenbach wrote:
> Reserving 26 for a new s390 bot in a follow up CL to avoid yet another master
> restart.

Not sure I understand. Are we going to decommission slave26-c3? what is s390?
How would it save us master restart?

https://codereview.chromium.org/1858233002/diff/60001/scripts/slave/bot_updat...
File scripts/slave/bot_update.py (right):

https://codereview.chromium.org/1858233002/diff/60001/scripts/slave/bot_updat...
scripts/slave/bot_update.py:274: 'client.v8.ports',
On 2016/04/05 14:50:03, Michael Achenbach wrote:
> Wonder what this file is still doing here. The same is in depot tools as a
> resource. The change there was necessary for this to work:
> https://codereview.chromium.org/1858193002/
> 
> I change it here too for consistency.

Acknowledged.

[Michael Achenbach, 2016-04-05 17:32:51]

https://codereview.chromium.org/1858233002/diff/60001/masters/master.client.v...
File masters/master.client.v8/slaves.cfg (left):

https://codereview.chromium.org/1858233002/diff/60001/masters/master.client.v...
masters/master.client.v8/slaves.cfg:336: for vm in [3, 4, 5, 26]:
On 2016/04/05 15:04:09, Sergiy Byelozyorov wrote:
> On 2016/04/05 14:50:03, Michael Achenbach wrote:
> > Reserving 26 for a new s390 bot in a follow up CL to avoid yet another
master
> > restart.
> 
> Not sure I understand. Are we going to decommission slave26-c3? what is s390?
> How would it save us master restart?

s390 is an architecture and v8 is going to port it. For that I'll add a builder
on the waterfall client.v8.ports in a different CL. I'll save restarting
client.v8 another time if I don't switch the slave in that follow up CL
(restarting client.v8 is annoying as many devs rely on it and it's slow on
startup).

[Michael Achenbach, 2016-04-05 17:55:52]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-04-05 17:55:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1858233002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1858233002/60001

[commit-bot: I haz the power, 2016-04-05 18:00:37]

Description was changed from

==========
V8: Move x87 builders to new master.

BUG=485955
==========

to

==========
V8: Move x87 builders to new master.

BUG=485955

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299703
==========

[commit-bot: I haz the power, 2016-04-05 18:00:39]

Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299703