Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1858193002: V8: Add new v8 master to bot_update. (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M recipe_modules/bot_update/resources/bot_update.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Michael Achenbach
PTAL. I find this kind of forward reference highly annoying...
4 years, 8 months ago (2016-04-05 10:53:57 UTC) #3
Sergiy Byelozyorov
lgtm
4 years, 8 months ago (2016-04-05 11:36:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858193002/1
4 years, 8 months ago (2016-04-05 11:37:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/147)
4 years, 8 months ago (2016-04-05 11:41:53 UTC) #8
Michael Achenbach
TBR'ing an owner
4 years, 8 months ago (2016-04-05 12:57:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858193002/1
4 years, 8 months ago (2016-04-05 12:57:58 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 13:00:30 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299695

Powered by Google App Engine
This is Rietveld 408576698