third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp - Issue 1858163002: Rename inDocument() to inShadowIncludingDocument()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp

Issue 1858163002: Rename inDocument() to inShadowIncludingDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp b/third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp

index 8cb6cb5793e6f0eadab15b912b589c04f9f34672..7f6063e64e19f3309d96eeaa0552b055a1eaa3e7 100644

--- a/third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp

@@ -120,7 +120,7 @@ bool SVGTextPathElement::layoutObjectIsNeeded(const ComputedStyle& style)

void SVGTextPathElement::buildPendingResource()

{

clearResourceReferences();

- if (!inDocument())

+ if (!inShadowIncludingDocument())

return;

AtomicString id;

@@ -154,7 +154,7 @@ Node::InsertionNotificationRequest SVGTextPathElement::insertedInto(ContainerNod

void SVGTextPathElement::removedFrom(ContainerNode* rootParent)

{

SVGTextContentElement::removedFrom(rootParent);

- if (rootParent->inDocument())

+ if (rootParent->inShadowIncludingDocument())

clearResourceReferences();

}