third_party/WebKit/Source/core/html/HTMLSelectElement.cpp - Issue 1858163002: Rename inDocument() to inShadowIncludingDocument()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 1858163002: Rename inDocument() to inShadowIncludingDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

index 1c2af0ea6654478fede894825e28c67c030b0410..f6d1a5bd1ebcbbf54887df734c25485369ed2e20 100644

--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

@@ -784,7 +784,7 @@ void HTMLSelectElement::setRecalcListItems()

m_shouldRecalcListItems = true;

setOptionsChangedOnLayoutObject();

- if (!inDocument()) {

+ if (!inShadowIncludingDocument()) {

if (HTMLOptionsCollection* collection = cachedCollection<HTMLOptionsCollection>(SelectOptions))

collection->invalidateCache();

invalidateSelectedItems();

@@ -946,7 +946,7 @@ void HTMLSelectElement::scrollToOption(HTMLOptionElement* option)

void HTMLSelectElement::scrollToOptionTask()

{

RawPtr<HTMLOptionElement> option = m_optionToScrollTo.release();

- if (!option || !inDocument())

+ if (!option || !inShadowIncludingDocument())

return;

// optionRemoved() makes sure m_optionToScrollTo doesn't have an option with

// another owner.