third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp - Issue 1858163002: Rename inDocument() to inShadowIncludingDocument()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp

Issue 1858163002: Rename inDocument() to inShadowIncludingDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp b/third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp

index b594c0f33826175db9ee1783a23c8734cc8025b4..9d3ace9791712a2459b89eeb60ebbfdbe90e68f6 100644

--- a/third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp

@@ -196,7 +196,7 @@ void HTMLFrameSetElement::defaultEventHandler(Event* evt)

Node::InsertionNotificationRequest HTMLFrameSetElement::insertedInto(ContainerNode* insertionPoint)

{

- if (insertionPoint->inDocument() && document().frame()) {

+ if (insertionPoint->inShadowIncludingDocument() && document().frame()) {

// A document using <frameset> likely won't literally have a body, but as far as the client is concerned, the frameset is effectively the body.

document().frame()->loader().client()->dispatchWillInsertBody();

}