third_party/WebKit/Source/core/html/HTMLDialogElement.cpp - Issue 1858163002: Rename inDocument() to inShadowIncludingDocument()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLDialogElement.cpp

Issue 1858163002: Rename inDocument() to inShadowIncludingDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLDialogElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLDialogElement.cpp b/third_party/WebKit/Source/core/html/HTMLDialogElement.cpp

index 953a6cee67fd65357c0cf4c7207e20a117f0eff2..018752047bf43fc034442ec325a520a46d7091cd 100644

--- a/third_party/WebKit/Source/core/html/HTMLDialogElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLDialogElement.cpp

@@ -153,7 +153,7 @@ void HTMLDialogElement::showModal(ExceptionState& exceptionState)

exceptionState.throwDOMException(InvalidStateError, "The element already has an 'open' attribute, and therefore cannot be opened modally.");

return;

}

- if (!inDocument()) {

+ if (!inShadowIncludingDocument()) {

exceptionState.throwDOMException(InvalidStateError, "The element is not in a Document.");

return;

}