third_party/WebKit/Source/core/editing/DOMSelection.cpp - Issue 1858163002: Rename inDocument() to inShadowIncludingDocument()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/DOMSelection.cpp

Issue 1858163002: Rename inDocument() to inShadowIncludingDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/DOMSelection.cpp

diff --git a/third_party/WebKit/Source/core/editing/DOMSelection.cpp b/third_party/WebKit/Source/core/editing/DOMSelection.cpp

index 27cd215fe716607ca37b4b44533a735d84442dc5..69c0d6766a6609691659fad19b97e4cdfad6a39f 100644

--- a/third_party/WebKit/Source/core/editing/DOMSelection.cpp

+++ b/third_party/WebKit/Source/core/editing/DOMSelection.cpp

@@ -402,7 +402,7 @@ void DOMSelection::addRange(Range* newRange)

if (!m_frame)

return;

- if (!newRange->inDocument()) {

+ if (!newRange->inShadowIncludingDocument()) {

addConsoleError("The given range isn't in document.");

return;

}