third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h - Issue 1858163002: Rename inDocument() to inShadowIncludingDocument()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h

Issue 1858163002: Rename inDocument() to inShadowIncludingDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h

diff --git a/third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h b/third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h

index 85ad569576a50c8cd43a7182b7ae26d3a942f666..11c781262f3370e22c65611f82fdcfc597aadd33 100644

--- a/third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h

+++ b/third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h

@@ -39,7 +39,7 @@ public:

explicit RangeBoundaryPoint(const RangeBoundaryPoint&);

- bool inDocument() const;

+ bool inShadowIncludingDocument() const;

const Position toPosition() const;

Node* container() const;

@@ -107,9 +107,9 @@ inline void RangeBoundaryPoint::ensureOffsetIsValid() const

m_offsetInContainer = m_childBeforeBoundary->nodeIndex() + 1;

}

-inline bool RangeBoundaryPoint::inDocument() const

+inline bool RangeBoundaryPoint::inShadowIncludingDocument() const

{

- return m_containerNode && m_containerNode->inDocument();

+ return m_containerNode && m_containerNode->inShadowIncludingDocument();

}

inline const Position RangeBoundaryPoint::toPosition() const