Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: third_party/WebKit/Source/core/dom/Fullscreen.cpp

Issue 1858163002: Rename inDocument() to inShadowIncludingDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Fullscreen.cpp
diff --git a/third_party/WebKit/Source/core/dom/Fullscreen.cpp b/third_party/WebKit/Source/core/dom/Fullscreen.cpp
index a51865ef68afb3775e92e780e0bf79c634269110..8c710b2072cb3e58f57613b4e15595f0758d57f2 100644
--- a/third_party/WebKit/Source/core/dom/Fullscreen.cpp
+++ b/third_party/WebKit/Source/core/dom/Fullscreen.cpp
@@ -85,7 +85,7 @@ static bool fullscreenElementReady(const Element& element)
// following are true, and false otherwise:
// |element| is in a document.
- if (!element.inDocument())
+ if (!element.inShadowIncludingDocument())
return false;
// |element|'s node document's fullscreen enabled flag is set.
@@ -362,7 +362,7 @@ void Fullscreen::exitFullscreen()
// If doc's fullscreen element stack is non-empty and the element now at the top is either
// not in a document or its node document is not doc, repeat this substep.
newTop = fullscreenElementFrom(*currentDoc);
- if (newTop && (!newTop->inDocument() || newTop->document() != currentDoc))
+ if (newTop && (!newTop->inShadowIncludingDocument() || newTop->document() != currentDoc))
continue;
// 2. Queue a task to fire an event named fullscreenchange with its bubbles attribute set to true
@@ -558,7 +558,7 @@ void Fullscreen::eventQueueTimerFired(Timer<Fullscreen>*)
Node* target = event->target()->toNode();
// If the element was removed from our tree, also message the documentElement.
- if (!target->inDocument() && document()->documentElement()) {
+ if (!target->inShadowIncludingDocument() && document()->documentElement()) {
ASSERT(isPrefixed(event->type()));
eventQueue.append(createEvent(event->type(), *document()->documentElement()));
}
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | third_party/WebKit/Source/core/dom/IntersectionObservation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698