Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: third_party/WebKit/Source/web/TextFinder.cpp

Issue 1858163002: Rename inDocument() to inShadowIncludingDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/TextFinder.cpp
diff --git a/third_party/WebKit/Source/web/TextFinder.cpp b/third_party/WebKit/Source/web/TextFinder.cpp
index 0443f934ab218e942161bb787dea147462b33b2f..9c31571668929149a791d92bc1341e01e1df6050 100644
--- a/third_party/WebKit/Source/web/TextFinder.cpp
+++ b/third_party/WebKit/Source/web/TextFinder.cpp
@@ -500,7 +500,7 @@ void TextFinder::updateFindMatchRects()
size_t deadMatches = 0;
for (FindMatch& match : m_findMatchesCache) {
- if (!match.m_range->boundaryPointsValid() || !match.m_range->startContainer()->inDocument())
+ if (!match.m_range->boundaryPointsValid() || !match.m_range->startContainer()->inShadowIncludingDocument())
match.m_rect = FloatRect();
else if (!m_findMatchRectsAreValid)
match.m_rect = findInPageRectFromRange(match.m_range.get());
@@ -605,7 +605,7 @@ int TextFinder::selectFindMatch(unsigned index, WebRect* selectionRect)
ASSERT_WITH_SECURITY_IMPLICATION(index < m_findMatchesCache.size());
RawPtr<Range> range = m_findMatchesCache[index].m_range;
- if (!range->boundaryPointsValid() || !range->startContainer()->inDocument())
+ if (!range->boundaryPointsValid() || !range->startContainer()->inShadowIncludingDocument())
return -1;
// Check if the match is already selected.

Powered by Google App Engine
This is Rietveld 408576698