Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 1858163002: Rename inDocument() to inShadowIncludingDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
index 9182cce29ee8b472f5e6dbb40b605f0f70e27275..6bb649efae9f73af8e0dddb55e05cb3adb2e723a 100644
--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
@@ -784,7 +784,7 @@ void HTMLSelectElement::setRecalcListItems()
m_shouldRecalcListItems = true;
setOptionsChangedOnLayoutObject();
- if (!inDocument()) {
+ if (!inShadowIncludingDocument()) {
if (HTMLOptionsCollection* collection = cachedCollection<HTMLOptionsCollection>(SelectOptions))
collection->invalidateCache();
invalidateSelectedItems();
@@ -946,7 +946,7 @@ void HTMLSelectElement::scrollToOption(HTMLOptionElement* option)
void HTMLSelectElement::scrollToOptionTask()
{
RawPtr<HTMLOptionElement> option = m_optionToScrollTo.release();
- if (!option || !inDocument())
+ if (!option || !inShadowIncludingDocument())
return;
// optionRemoved() makes sure m_optionToScrollTo doesn't have an option with
// another owner.

Powered by Google App Engine
This is Rietveld 408576698