Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 1858163002: Rename inDocument() to inShadowIncludingDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index 0e2c06a7a470142e4c48b90c2d8472efc7d1dd6d..d3dfaf17ed41b2d2cb989e9e26c54ddc0ce75b1d 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -621,7 +621,7 @@ Node::InsertionNotificationRequest HTMLMediaElement::insertedInto(ContainerNode*
WTF_LOG(Media, "HTMLMediaElement::insertedInto(%p, %p)", this, insertionPoint);
HTMLElement::insertedInto(insertionPoint);
- if (insertionPoint->inDocument()) {
+ if (insertionPoint->inShadowIncludingDocument()) {
UseCounter::count(document(), UseCounter::HTMLMediaElementInDocument);
if (!getAttribute(srcAttr).isEmpty() && m_networkState == NETWORK_EMPTY) {
m_ignorePreloadNone = false;
@@ -3462,13 +3462,13 @@ void HTMLMediaElement::ensureMediaControls()
assertShadowRootChildren(shadowRoot);
- if (!shouldShowControls() || !inDocument())
+ if (!shouldShowControls() || !inShadowIncludingDocument())
mediaControls->hide();
}
void HTMLMediaElement::configureMediaControls()
{
- if (!inDocument()) {
+ if (!inShadowIncludingDocument()) {
if (mediaControls())
mediaControls()->hide();
return;

Powered by Google App Engine
This is Rietveld 408576698