third_party/WebKit/Source/core/html/HTMLLabelElement.cpp - Issue 1858163002: Rename inDocument() to inShadowIncludingDocument()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLLabelElement.cpp

Issue 1858163002: Rename inDocument() to inShadowIncludingDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLLabelElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp b/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp

index 6d182e74de929b2d723745e871b07b0a06fc73ea..4d34464269a88164f70cb7d19ebc76145db72bda 100644

--- a/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp

@@ -245,7 +245,7 @@ void HTMLLabelElement::accessKeyAction(bool sendMouseEvents)

void HTMLLabelElement::updateLabel(TreeScope& scope, const AtomicString& oldForAttributeValue, const AtomicString& newForAttributeValue)

{

- if (!inDocument())

+ if (!inShadowIncludingDocument())

return;

if (oldForAttributeValue == newForAttributeValue)

@@ -268,7 +268,7 @@ Node::InsertionNotificationRequest HTMLLabelElement::insertedInto(ContainerNode*

}

// Trigger for elements outside of forms.

- if (!formOwner() && insertionPoint->inDocument())

+ if (!formOwner() && insertionPoint->inShadowIncludingDocument())

document().didAssociateFormControl(this);

return result;